Date: Thu, 27 Sep 2001 17:27:14 -0700 (PDT) From: Julian Elischer <julian@elischer.org> To: Garrett Wollman <wollman@khavrinen.lcs.mit.edu> Cc: obrien@FreeBSD.org, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/sys proc.h Message-ID: <Pine.BSF.4.21.0109271716250.65838-100000@InterJet.elischer.org> In-Reply-To: <200109272214.f8RME1v06093@khavrinen.lcs.mit.edu>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 27 Sep 2001, Garrett Wollman wrote: > <<On Thu, 27 Sep 2001 15:06:46 -0700, "David O'Brien" <obrien@FreeBSD.org> said: > > > It doesn't matter *jack* what you think. > > style(9) is explicitly clear how this should be formatted in > > FreeBSD-land. Get consensus to change style(9) if you don't like it. > > But follow it until you do. > > How could Julian ever gain concensus if people like you start jumping > down people's throats any time someone tries to make a change. > > Ordinarily I would say that one should just make a change and see how > well it's received, but I can understand why people would not be > interested in putting up with this sort of abuse. > > I personally don't think that any change is needed, other than > recognizing some flexibility in the layout of complex data > structures. The world will not come to an end if someone uses two > tabs to align fields instead of one. Personally I'd like to see something that says like: "small variations to this rule, for the purpose of aligning related fields and increasign readability are accepteble." and maybe an example struct foo { int foo_a; /* comment */ struct freddy foo_b; /* Comment aligned as above. */ union bigwords *foo_c; /* All comments aligned */ unsigned char foo_chars; /* to allow the eye to scan them */ /* With overflow also aligned */ /* the same as above. */ struct bigstructures foo_vals[NUMSTRUCTS]; /* sometimes you just */ /* have to bend the rules */ }; > > -GAWollman > > To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.21.0109271716250.65838-100000>