Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 28 Jul 2008 20:54:34 -0400
From:      Yarema <yds@CoolRat.org>
To:        FreeBSD-gnats-submit@FreeBSD.org
Cc:        robin@isometry.net, Geoffroy Desvernay <dgeo@ec-marseille.fr>
Subject:   ports/126059: [PATCH] mail/dovecot-managesieve 
Message-ID:  <courier.00000000488E6A4A.000027C8@dppl.com>
Resent-Message-ID: <200807290100.m6T108rC057659@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         126059
>Category:       ports
>Synopsis:       [PATCH] mail/dovecot-managesieve
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Tue Jul 29 01:00:08 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator:     Yarema
>Release:        FreeBSD 6.3-STABLE amd64
>Organization:
NYCBUG.org
>Environment:
	FreeBSD 6.3-STABLE amd64
	FreeBSD 7.0-STABLE amd64
>Description:
Fix the text in pkg-descr and pkg-message to be about mail/dovecot-managesieve
and not the port it was copied from.

Fix PORTNAME so no version number is hardcoded and add DISTNAME to fetch the
correct tarball.

Change the COMMENT to be more descriptive.

Change RUN_DEPENDS to reference the installed ports and versions being depended on.

Fix CONFIGURE_ARGS to use ${MAKE} rather than hardcoding "make" and split to
multiple lines for readability.

See http://www.FreeBSD.org/cgi/query-pr.cgi?pr=126054 for corresponding patch to
mail/dovecot adding ManageSieve support which enables mail/dovecot-managesieve
port to work as intended.
>How-To-Repeat:
>Fix:
diff -u -r -N dovecot-managesieve~/Makefile dovecot-managesieve/Makefile
--- dovecot-managesieve~/Makefile	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/Makefile	2008-07-28 19:11:25.950630433 -0400
@@ -5,20 +5,26 @@
 # $FreeBSD: ports/mail/dovecot-managesieve/Makefile,v 1.1 2008/07/19 10:11:14 miwi Exp $
 #
 
-PORTNAME=	dovecot-1.1-managesieve
+PORTNAME=	dovecot-managesieve
 PORTVERSION=	0.10.3
 CATEGORIES=	mail
-MASTER_SITES=	http://www.rename-it.nl/dovecot/1.1/
+MASTER_SITES=	http://www.rename-it.nl/dovecot/${DOVECOTVERSION}/
+DISTNAME=	${PORTNAME:C/-/-${DOVECOTVERSION}-/}-${DISTVERSIONPREFIX}${DISTVERSION:C/:(.)/\1/g}${DISTVERSIONSUFFIX}
 
 MAINTAINER=	dgeo@ec-marseille.fr
-COMMENT=	Managesieve package
+COMMENT=	Dovecot ManageSieve Server daemon
 
 BUILD_DEPENDS=	${NONEXISTENT}:${PORTSDIR}/mail/dovecot:build \
 		${NONEXISTENT}:${PORTSDIR}/mail/dovecot-sieve:build
-RUN_DEPENDS=	${LOCALBASE}/lib/dovecot/lda/lib90_cmusieve_plugin.so:${PORTSDIR}/mail/dovecot-sieve
+RUN_DEPENDS=	dovecot>=1.1.*:${PORTSDIR}/mail/dovecot \
+		dovecot-sieve>=1.1.*:${PORTSDIR}/mail/dovecot-sieve
+
+DOVECOTVERSION=	1.1
 
 GNU_CONFIGURE=	yes
 CONFIGURE_TARGET=	--build=${MACHINE_ARCH}-portbld-freebsd${OSREL}
-CONFIGURE_ARGS=	--prefix=${PREFIX} --with-dovecot=`make -C ${PORTSDIR}/mail/dovecot -V WRKSRC` --with-dovecot-sieve=`make -C ${PORTSDIR}/mail/dovecot-sieve -V WRKSRC`
+CONFIGURE_ARGS=	--prefix=${PREFIX} \
+		--with-dovecot=`${MAKE} -C ${PORTSDIR}/mail/dovecot -V WRKSRC` \
+		--with-dovecot-sieve=`${MAKE} -C ${PORTSDIR}/mail/dovecot-sieve -V WRKSRC`
 
 .include <bsd.port.mk>
diff -u -r -N dovecot-managesieve~/distinfo dovecot-managesieve/distinfo
--- dovecot-managesieve~/distinfo	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/distinfo	2008-07-28 11:39:22.374073032 -0400
@@ -1,3 +1,3 @@
-SIZE (dovecot-1.1-managesieve-0.10.3.tar.gz) = 395123
 MD5 (dovecot-1.1-managesieve-0.10.3.tar.gz) = 14ad3bdec508bad8bcce35b57681d255
 SHA256 (dovecot-1.1-managesieve-0.10.3.tar.gz) = ac70ee48cdec2d472c14cb93bc9f3339a30763e418a579ddea0b9b18befac5ac
+SIZE (dovecot-1.1-managesieve-0.10.3.tar.gz) = 395123
diff -u -r -N dovecot-managesieve~/pkg-descr dovecot-managesieve/pkg-descr
--- dovecot-managesieve~/pkg-descr	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/pkg-descr	2008-04-22 20:56:38.000000000 -0400
@@ -1,9 +1,7 @@
-From the Dovecot wiki on LDA (WWW: http://wiki.dovecot.org/LDA/Sieve)
+Dovecot native ManageSieve implementation
 
-Sieve language support by a plugin for the deliver LDA
+Provides ManageSieve protocol service giving users the ability to
+upload their own Sieve scripts to the server, i.e. without the need
+for shell or FTP access.
 
-    * Mail filtering
-    * Mail forwarding
-    * Vacation auto-reply
-
-WWW:	http://www.dovecot.org
+WWW:	http://Wiki.Dovecot.org/ManageSieve
diff -u -r -N dovecot-managesieve~/pkg-message dovecot-managesieve/pkg-message
--- dovecot-managesieve~/pkg-message	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/pkg-message	2008-04-22 20:59:26.000000000 -0400
@@ -1,16 +1,20 @@
----------------------------------------------------------------------
+----------------------------------------------------------------------
  
- This port assumes you are known with Dovecot and have it installed
- and running on the system you have installed this plugin on.
+ This port assumes you are familiar with Dovecot and have it installed
+ and running on the system you have installed this service on.
 
- You can enable the plugin with this directive in your dovecot.conf:
+ You can enable the service with this directive in your dovecot.conf:
 
-     protocol lda {
-  	mail_plugins = cmusieve
+     protocol managesieve {
+	sieve=~/.dovecot.sieve
+	sieve_storage=~/sieve
      }
 
+ And don't forget to add "managesieve" to the "protocols" setting
+ if you use it. 
+
  Further information on configuration can be found at:
  
-  http://wiki.dovecot.org/
+  http://Wiki.Dovecot.org/ManageSieve
 
----------------------------------------------------------------------
+----------------------------------------------------------------------
diff -u -r -N dovecot-managesieve~/pkg-plist dovecot-managesieve/pkg-plist
--- dovecot-managesieve~/pkg-plist	2008-07-19 06:11:14.000000000 -0400
+++ dovecot-managesieve/pkg-plist	2008-04-22 21:32:29.000000000 -0400
@@ -1,4 +1,4 @@
-@comment $ID:$
+@comment $FreeBSD: $
 libexec/dovecot/managesieve
 libexec/dovecot/managesieve-login
 @dirrmtry libexec/dovecot
>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?courier.00000000488E6A4A.000027C8>