From owner-svn-ports-head@freebsd.org Sun Jun 30 08:14:56 2019 Return-Path: Delivered-To: svn-ports-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 630B115CF7D9; Sun, 30 Jun 2019 08:14:56 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: from mail-vk1-f176.google.com (mail-vk1-f176.google.com [209.85.221.176]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 0984975A0D; Sun, 30 Jun 2019 08:14:55 +0000 (UTC) (envelope-from thomas.e.zander@googlemail.com) Received: by mail-vk1-f176.google.com with SMTP id 9so2099738vkw.4; Sun, 30 Jun 2019 01:14:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=w+OG7XtON2uTPlHIq0vwCQw9sVu1OQxlTu19yEub8Fc=; b=JZ1OhArtOIEeoHgsVR+lqDIOaPjoi3SpJ36iaGfanrsyWkooOcYgo1onFdgz1jH3yO OD15Okeb2zFa0nZ3XDpl0ol6FnIy7dCrP+bLn0EZd0qQTSL/qzVtrZfiuPJ7WYVX5fnn NP3dX4B/hORVV/ZH582H1ZWO1IPJmC8sFGPCw9+9cfrOSartdU7P9Xfp9dZb1nyl5SdH SDOkf/vkLJ6O5CezXqb+UTvFIAlE4IrADxzswqSK9AopYZiPS1AGlSI/Dv7CJctlUHou knc8n14kCXwvjnWIYpB2ZyDovjDVWDzUUbWWgu/P5CMrY4ZYt3ICUt+aFx61ZiTIZ3I0 OQAA== X-Gm-Message-State: APjAAAUAb/nj5bfb71G5lp7hjM1+4jswuXu2ZO9tBC5tHA94Qmfsm6DO Q094TjgHt1oRsYkerfmOQtZ14kRx6JJ3EJSVk8SzSGTodyY= X-Google-Smtp-Source: APXvYqwEmBfPnpYN2Mq91To1HgmgY/envn+r4loNTNiREkd039jf2soDltXzlXs7w13t55epBoAbNaMBN4GVwX6Gf7U= X-Received: by 2002:a65:4cc4:: with SMTP id n4mr16657549pgt.307.1561841455911; Sat, 29 Jun 2019 13:50:55 -0700 (PDT) MIME-Version: 1.0 References: <201906291312.x5TDCkK1030164@repo.freebsd.org> <20190629150321.GA97932@FreeBSD.org> In-Reply-To: <20190629150321.GA97932@FreeBSD.org> From: Thomas Zander Date: Sat, 29 Jun 2019 22:50:41 +0200 Message-ID: Subject: Re: svn commit: r505349 - in head/multimedia: mencoder mplayer mplayer/files To: Alexey Dokuchaev Cc: "ports-committers@FreeBSD.org" , svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 0984975A0D X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.88 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-0.999,0]; NEURAL_HAM_SHORT(-0.89)[-0.885,0]; REPLY(-4.00)[]; TAGGED_FROM(0.00)[]; NEURAL_HAM_LONG(-1.00)[-1.000,0] X-BeenThere: svn-ports-head@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree for head List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 30 Jun 2019 08:14:56 -0000 On Sat, 29 Jun 2019 at 17:03, Alexey Dokuchaev wrote: > The fact that you've dropped the RTC option is obvious from the commit diff > itself. What's not obvious (and thus should be part of the commit log) is > the reasons behind this decision. The advantages of supporting it have always been somewhat questionable. Personally, I have never encountered a single issue that could be solved by enabling RTC. Also most of our video-playing user base have not been able to use it for quite some time anyway, with nobody complaining: > grep BROKEN /usr/ports/emulators/rtc/Makefile BROKEN_FreeBSD_12= fails to compile: rtc.c:166:2: implicit declaration of function 'MALLOC' is invalid in C99 BROKEN_FreeBSD_13= fails to compile: rtc.c:166:2: implicit declaration of function 'MALLOC' is invalid in C99 Riggs