Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 2 Apr 2007 18:48:27 -0700
From:      Marcel Moolenaar <xcllnt@mac.com>
To:        "Greg 'groggy' Lehey" <grog@FreeBSD.org>
Cc:        cvs-src@FreeBSD.org, Marcel Moolenaar <marcel@FreeBSD.org>, cvs-all@FreeBSD.org, src-committers@FreeBSD.org
Subject:   Re: cvs commit: src Makefile
Message-ID:  <1F21AA9B-4D6B-4C67-BF6B-ED63B7E7EB14@mac.com>
In-Reply-To: <20070403012527.GH19923@wantadilla.lemis.com>
References:  <200704022132.l32LWjwt084642@repoman.freebsd.org> <20070403012527.GH19923@wantadilla.lemis.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Apr 2, 2007, at 6:25 PM, Greg 'groggy' Lehey wrote:

> On Monday,  2 April 2007 at 21:32:44 +0000, Marcel Moolenaar wrote:
>> marcel      2007-04-02 21:32:44 UTC
>>
>>   FreeBSD src repository
>>
>>   Modified files:
>>     .                    Makefile
>>   Log:
>>   Introduce a variable TARGETS that can be set on the make command
>>   line
>
> This sounded excellent until I read on.
>
>>   and that controls which platforms are being built as part of a
>>   "make universe".
>
> That's not quite what I had expected with a variable called TARGETS.
> Wouldn't PLATFORMS be more "intuitive"?

Maybe. I chose TARGETS because the loop in question was:
	.for target in amd64 arm i386 ...

Also, TARGETS is in line with TARGET and/or TARGET_ARCH, which
relate closely to MACHINE and MACHINE_ARCH. It seems a good
choice to me...

I don't mind if people change it to a different name, whether more
intuitive to promote its use or less intuitive to limit/demote its
use. I just like having the functionality because it allows me to
use make universe more often :-)

-- 
Marcel Moolenaar
xcllnt@mac.com





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1F21AA9B-4D6B-4C67-BF6B-ED63B7E7EB14>