Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 25 Apr 2006 15:39:57 -0400
From:      John Baldwin <jhb@freebsd.org>
To:        Scott Long <scottl@samsco.org>
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org
Subject:   Re: cvs commit: src/sys/dev/bce if_bcereg.h
Message-ID:  <200604251540.00170.jhb@freebsd.org>
In-Reply-To: <444E7750.206@samsco.org>
References:  <200604251918.k3PJImQA007820@repoman.freebsd.org> <444E7750.206@samsco.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tuesday 25 April 2006 15:24, Scott Long wrote:
> John Baldwin wrote:
> > jhb         2006-04-25 19:18:48 UTC
> > 
> >   FreeBSD src repository
> > 
> >   Modified files:
> >     sys/dev/bce          if_bcereg.h 
> >   Log:
> >   Fix half of the current i386 tinderbox failure.  max_bus_addr should be a
> >   bus_addr_t rather than a bus_size_t.
> >   
> >   Revision  Changes    Path
> >   1.2       +1 -1      src/sys/dev/bce/if_bcereg.h
> 
> Actually, bus_size_t should also be aware of PAE.

That may be true as well, I'll defer to your judgement on that one.  In
this case bus_dma_tag_create()'s low_addr argument is supposed to be a
bus_addr_t according to the man page. :)

-- 
John Baldwin <jhb@FreeBSD.org>  <><  http://www.FreeBSD.org/~jhb/
"Power Users Use the Power to Serve"  =  http://www.FreeBSD.org



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200604251540.00170.jhb>