From owner-svn-src-all@FreeBSD.ORG Tue Mar 6 15:39:55 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id DFDEB106567E; Tue, 6 Mar 2012 15:39:55 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from cyrus.watson.org (cyrus.watson.org [65.122.17.42]) by mx1.freebsd.org (Postfix) with ESMTP id B752D8FC16; Tue, 6 Mar 2012 15:39:55 +0000 (UTC) Received: from bigwig.baldwin.cx (bigwig.baldwin.cx [96.47.65.170]) by cyrus.watson.org (Postfix) with ESMTPSA id 707E846B55; Tue, 6 Mar 2012 10:39:55 -0500 (EST) Received: from jhbbsd.localnet (unknown [209.249.190.124]) by bigwig.baldwin.cx (Postfix) with ESMTPSA id CB8F2B90E; Tue, 6 Mar 2012 10:39:54 -0500 (EST) From: John Baldwin To: Dimitry Andric Date: Tue, 6 Mar 2012 08:35:16 -0500 User-Agent: KMail/1.13.5 (FreeBSD/8.2-CBSD-20110714-p10; KDE/4.5.5; amd64; ; ) References: <201203051953.q25JrIS1002269@svn.freebsd.org> <4F55F652.2040908@FreeBSD.org> In-Reply-To: <4F55F652.2040908@FreeBSD.org> MIME-Version: 1.0 Content-Type: Text/Plain; charset="utf-8" Content-Transfer-Encoding: 7bit Message-Id: <201203060835.16865.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (bigwig.baldwin.cx); Tue, 06 Mar 2012 10:39:54 -0500 (EST) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r232570 - head/sys/boot/i386/boot2 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Mar 2012 15:39:56 -0000 On Tuesday, March 06, 2012 6:34:42 am Dimitry Andric wrote: > On 2012-03-05 20:53, John Baldwin wrote: > > Author: jhb > > Date: Mon Mar 5 19:53:17 2012 > > New Revision: 232570 > > URL: http://svn.freebsd.org/changeset/base/232570 > > > > Log: > > Fix boot2 to handle boot config files that only contain a custom path to > > a loader or kernel. Specifically, kname cannot be pointed at cmd[] since > > it's value is change to be an empty string after the initial call to > > parse, and cmd[]'s value can be changed (thus losing a prior setting for > > kname) due to user input at the boot prompt. While here, ensure that that > > initial boot config file text is nul-terminated, that ops is initialized > > to zero, and that kname is always initialized to a valid string. > > Sigh, this broke building boot2 with clang again... :( I only put back 1 of the memcpy's instead of 3 to try to make it as small as possible. :( The problem is the last round of changes to shrink it broke functionality. -- John Baldwin