From owner-freebsd-pf@FreeBSD.ORG Wed Mar 2 19:17:00 2005 Return-Path: Delivered-To: freebsd-pf@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id CBBDD16A4CE for ; Wed, 2 Mar 2005 19:17:00 +0000 (GMT) Received: from relay.bestcom.ru (relay.bestcom.ru [217.72.144.5]) by mx1.FreeBSD.org (Postfix) with ESMTP id B899243D54 for ; Wed, 2 Mar 2005 19:16:59 +0000 (GMT) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (root@cell.sick.ru [217.72.144.68]) by relay.bestcom.ru (8.13.1/8.12.9) with ESMTP id j22JGvt7008653 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=FAIL); Wed, 2 Mar 2005 22:16:57 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: from cell.sick.ru (glebius@localhost [127.0.0.1]) by cell.sick.ru (8.13.1/8.12.8) with ESMTP id j22JGu3o093418 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 2 Mar 2005 22:16:57 +0300 (MSK) (envelope-from glebius@FreeBSD.org) Received: (from glebius@localhost) by cell.sick.ru (8.13.1/8.13.1/Submit) id j22JGuUH093417; Wed, 2 Mar 2005 22:16:56 +0300 (MSK) (envelope-from glebius@FreeBSD.org) X-Authentication-Warning: cell.sick.ru: glebius set sender to glebius@FreeBSD.org using -f Date: Wed, 2 Mar 2005 22:16:56 +0300 From: Gleb Smirnoff To: Matthew Grooms Message-ID: <20050302191656.GA93112@cell.sick.ru> References: <200502282232.17646.max@love2party.net> <4223931C.9000607@seton.org> <200502282326.41760.max@love2party.net> <4224B078.9020301@seton.org> <20050301185431.GA81982@cell.sick.ru> <4225174C.801@seton.org> <20050302081051.GB87159@cell.sick.ru> <422600A2.2080907@seton.org> Mime-Version: 1.0 Content-Type: text/plain; charset=koi8-r Content-Disposition: inline In-Reply-To: <422600A2.2080907@seton.org> User-Agent: Mutt/1.5.6i X-Virus-Scanned: ClamAV version devel-20050125, clamav-milter version 0.80ff on relay.bestcom.ru X-Virus-Status: Clean cc: freebsd-pf@FreeBSD.org Subject: Re: Fwd: pf + pfsync + carp testing ... X-BeenThere: freebsd-pf@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list List-Id: Technical discussion and general questions about packet filter (pf) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 02 Mar 2005 19:17:01 -0000 Matthew, On Wed, Mar 02, 2005 at 12:06:26PM -0600, Matthew Grooms wrote: M> Thanks again for looking at this. I see the #ifdev DEV_CARP M> section in if_em.c file. I rebuilt the kernel after applying the patch M> and installed it so I assumed it was in there. I apologize in advance M> for my complete lack of kernel hacking knowledge. I went ahead and added ... M> M> if (ifp->if_carp) { M> carp_carpdev_state(ifp->if_carp); M> printf( "carp interface notified\n" ); M> ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ M> } M> M> ... for up/down to make sure the kernel was hitting that chunk of code. M> After a compile and reinstall, unfortunately I didn't see the output M> along with link state changes. I added a ... M> M> #define CARP_DEV 1 M> M> ... to the beginning of both if_em.c and if_em.h to force it to include M> the em carp support but got this compile error during the kernel build ... M> M> In file included from ../../../dev/em/if_em.h:68, M> from ../../../dev/em/if_em.c:38: M> ../../../netinet/ip_carp.h:158: warning: "struct in_ifaddr" declared M> inside parameter list M> ../../../netinet/ip_carp.h:158: warning: its scope is only this M> definition or declaration, which is probably not what you want M> *** Error code 1 M> M> Stop in /usr/src/sys/amd64/compile/CUSTOM. Yes. There was an error in there. Frank Volf has already showed me it in private mail. Sorry for this. I'm working in HEAD now, where miibus and em does not need this hacks. Fixed patch available at the same place: http://people.freebsd.org/~glebius/totest/carp-RELENG_5-patch M> I wish I had more kernel-foo as this is probably me shooting myself in M> the foot somehow. Anyways, Im not sure where to go from here. M> M> Just on a side note, I seem to vaguely remember seeing something M> the current mailing list about the em driver having problems reporting M> link states. When I did a search in the mailing list archives I found M> this commit message from you. Could this be applicable to the card I am M> using? M> M> http://www.freebsd.org/cgi/getmsg.cgi?fetch=2244676+2246764+/usr/local/www/db/text/2005/cvs-all/20050206.cvs-all Yes, but this change can't be MFCed due to ABI freeze for RELENG_5. That's why I'm doing these hacks for em in carp.RELENG_5-patch. -- Totus tuus, Glebius. GLEBIUS-RIPN GLEB-RIPE