Date: Wed, 15 Apr 2009 22:52:01 +0400 From: Oleg Bulyzhin <oleg@FreeBSD.org> To: Luigi Rizzo <luigi@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190865 - in head: sbin/ipfw sys/netinet Message-ID: <20090415185201.GA83843@lath.rinet.ru> In-Reply-To: <200904091246.n39Ck05i004627@svn.freebsd.org> References: <200904091246.n39Ck05i004627@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Converting numbytes (struct dn_pipe) to dn_key (which is uint64_t) may break WFQ. ready_event_wfq() code depends on signed 'numbytes'. P.S. i vote for modifing ready_event_wfq() to deal with unsigned numbytes. -- Oleg. ================================================================ === Oleg Bulyzhin -- OBUL-RIPN -- OBUL-RIPE -- oleg@rinet.ru === ================================================================
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090415185201.GA83843>