From owner-svn-src-all@FreeBSD.ORG Wed Apr 15 19:05:27 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 2D7C2106566B; Wed, 15 Apr 2009 19:05:27 +0000 (UTC) (envelope-from oleg@lath.rinet.ru) Received: from lath.rinet.ru (lath.rinet.ru [195.54.192.90]) by mx1.freebsd.org (Postfix) with ESMTP id DE36A8FC1F; Wed, 15 Apr 2009 19:05:26 +0000 (UTC) (envelope-from oleg@lath.rinet.ru) Received: by lath.rinet.ru (Postfix, from userid 222) id 162FE7049; Wed, 15 Apr 2009 22:52:01 +0400 (MSD) Date: Wed, 15 Apr 2009 22:52:01 +0400 From: Oleg Bulyzhin To: Luigi Rizzo Message-ID: <20090415185201.GA83843@lath.rinet.ru> References: <200904091246.n39Ck05i004627@svn.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200904091246.n39Ck05i004627@svn.freebsd.org> User-Agent: Mutt/1.5.18 (2008-05-17) Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r190865 - in head: sbin/ipfw sys/netinet X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 15 Apr 2009 19:05:28 -0000 Converting numbytes (struct dn_pipe) to dn_key (which is uint64_t) may break WFQ. ready_event_wfq() code depends on signed 'numbytes'. P.S. i vote for modifing ready_event_wfq() to deal with unsigned numbytes. -- Oleg. ================================================================ === Oleg Bulyzhin -- OBUL-RIPN -- OBUL-RIPE -- oleg@rinet.ru === ================================================================