From owner-cvs-all Wed Jan 9 4: 4:36 2002 Delivered-To: cvs-all@freebsd.org Received: from whale.sunbay.crimea.ua (whale.sunbay.crimea.ua [212.110.138.65]) by hub.freebsd.org (Postfix) with ESMTP id EC31437B420; Wed, 9 Jan 2002 04:04:20 -0800 (PST) Received: (from ru@localhost) by whale.sunbay.crimea.ua (8.11.6/8.11.2) id g09C4Fa63004; Wed, 9 Jan 2002 14:04:15 +0200 (EET) (envelope-from ru) Date: Wed, 9 Jan 2002 14:04:15 +0200 From: Ruslan Ermilov To: Sheldon Hearn Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/modules/smbfs Makefile Message-ID: <20020109140414.H41379@sunbay.com> References: <200201091145.g09BjwZ48508@freefall.freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200201091145.g09BjwZ48508@freefall.freebsd.org> User-Agent: Mutt/1.3.23i Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG On Wed, Jan 09, 2002 at 03:45:58AM -0800, Sheldon Hearn wrote: > sheldonh 2002/01/09 03:45:58 PST > > Modified files: > sys/modules/smbfs Makefile > Log: > Use KMODDEPS to document module dependencies on libiconv and > libmchain. > > KMODDEPS seems to be a no-op in HEAD, but is required in RELENG_4, > where MODULE_DEPEND seems to be a no-op. > > Therefore, this change is harmless in -CURRENT, but will fix the > dependencies when merged to RELENG_4, where they are currently not > registered! > > PR: kern/33625 > Submitted by: Joe Marcus Clarke > > Revision Changes Path > 1.2 +1 -0 src/sys/modules/smbfs/Makefile > It's not harmless but bogus. Please back this out. There's no such thing as KMODDEPS in -CURRENT: : RCS file: /home/ncvs/src/sys/conf/kmod.mk,v : ---------------------------- : revision 1.80 : date: 2000/05/01 18:06:49; author: peter; state: Exp; lines: +7 -19 : Remove KMODDEPS support. All our existing dependencies are specified : via the MODULE_VERSION() and MODULE_DEPEND() macros that both the loader : and kld system know how to deal with. The old DT_NEEDED tag is still : supported by the loader (and will remain supported for a while) - but the : kernel side presently doesn't know how to deal with DT_NEEDED. Please also feel free to remove KMODDEPS from sys/modules/dummynet/Makefile. Cheers, -- Ruslan Ermilov Oracle Developer/DBA, ru@sunbay.com Sunbay Software AG, ru@FreeBSD.org FreeBSD committer, +380.652.512.251 Simferopol, Ukraine http://www.FreeBSD.org The Power To Serve http://www.oracle.com Enabling The Information Age To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message