From owner-freebsd-ports-bugs@FreeBSD.ORG Tue Nov 30 14:10:11 2010 Return-Path: Delivered-To: freebsd-ports-bugs@hub.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 41C5B1065674 for ; Tue, 30 Nov 2010 14:10:11 +0000 (UTC) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id EDBDB8FC22 for ; Tue, 30 Nov 2010 14:10:10 +0000 (UTC) Received: from freefall.freebsd.org (localhost [127.0.0.1]) by freefall.freebsd.org (8.14.4/8.14.4) with ESMTP id oAUEAAFv078895 for ; Tue, 30 Nov 2010 14:10:10 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.14.4/8.14.4/Submit) id oAUEAAQU078894; Tue, 30 Nov 2010 14:10:10 GMT (envelope-from gnats) Resent-Date: Tue, 30 Nov 2010 14:10:10 GMT Resent-Message-Id: <201011301410.oAUEAAQU078894@freefall.freebsd.org> Resent-From: FreeBSD-gnats-submit@FreeBSD.org (GNATS Filer) Resent-To: freebsd-ports-bugs@FreeBSD.org Resent-Reply-To: FreeBSD-gnats-submit@FreeBSD.org, Alexander Brovikov Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 9C2A41065670 for ; Tue, 30 Nov 2010 14:03:39 +0000 (UTC) (envelope-from nobody@FreeBSD.org) Received: from red.freebsd.org (unknown [IPv6:2001:4f8:fff6::22]) by mx1.freebsd.org (Postfix) with ESMTP id 8A59F8FC14 for ; Tue, 30 Nov 2010 14:03:39 +0000 (UTC) Received: from red.freebsd.org (localhost [127.0.0.1]) by red.freebsd.org (8.14.4/8.14.4) with ESMTP id oAUE3cQn068941 for ; Tue, 30 Nov 2010 14:03:38 GMT (envelope-from nobody@red.freebsd.org) Received: (from nobody@localhost) by red.freebsd.org (8.14.4/8.14.4/Submit) id oAUE3cfq068940; Tue, 30 Nov 2010 14:03:38 GMT (envelope-from nobody) Message-Id: <201011301403.oAUE3cfq068940@red.freebsd.org> Date: Tue, 30 Nov 2010 14:03:38 GMT From: Alexander Brovikov To: freebsd-gnats-submit@FreeBSD.org X-Send-Pr-Version: www-3.1 Cc: Subject: ports/152703: [patch] net/asterisk add reload cmd to rc-script and correct path to pidfile X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Nov 2010 14:10:11 -0000 >Number: 152703 >Category: ports >Synopsis: [patch] net/asterisk add reload cmd to rc-script and correct path to pidfile >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Tue Nov 30 14:10:10 UTC 2010 >Closed-Date: >Last-Modified: >Originator: Alexander Brovikov >Release: 8.1-RELEASE >Organization: >Environment: FreeBSD vbox 8.1-RELEASE FreeBSD 8.1-RELEASE #0: Mon Jul 19 02:55:53 UTC 2010 root@almeida.cse.buffalo.edu:/usr/obj/usr/src/sys/GENERIC i386 >Description: I suggest patch for net/asterisk rc.d script that: - adds 'reload' command; - corrects default path to pidfile (otherwise 'status' cmd don't work); - renames 'asterisk_shutdown' to 'asterisk_stop'; - does some clean-up. Is 'sleep 1' & 'return 0' lines in 'asterisk_stop' really needed? >How-To-Repeat: >Fix: Patch attached with submission follows: --- /usr/local/etc/rc.d/asterisk.orig 2010-11-30 13:36:29.000000000 +0500 +++ /usr/local/etc/rc.d/asterisk 2010-11-30 18:57:26.000000000 +0500 @@ -11,24 +11,32 @@ . /etc/rc.subr -stop_cmd=asterisk_shutdown -asterisk_shutdown () { - echo 'Stopping asterisk' - /usr/local/sbin/asterisk -nqrx 'core stop now' - sleep 1 - return 0 -} name=asterisk rcvar=`set_rcvar` +extra_commands="reload" +load_rc_config $name + +stop_cmd="asterisk_stop" +reload_cmd="asterisk_reload" + +asterisk_enable=${asterisk_enable:-"NO"} -command=/usr/local/sbin/asterisk +command="/usr/local/sbin/asterisk" command_args="-n -U asterisk" +pidfile=${asterisk_pidfile:-"/var/run/asterisk/asterisk.pid"} -load_rc_config $name -pidfile=${asterisk_pidfile:-"/var/run/asterisk.pid"} +asterisk_stop () { + echo 'Stopping asterisk' + $command -nqrx 'core stop now' + sleep 1 + return 0 +} -asterisk_enable=${asterisk_enable:-"NO"} +asterisk_reload () { + echo 'Reloading asterisk' + $command -nqrx 'reload' +} run_rc_command "$1" >Release-Note: >Audit-Trail: >Unformatted: