From owner-freebsd-current@FreeBSD.ORG Wed Dec 10 19:58:02 2008 Return-Path: Delivered-To: freebsd-current@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id E624E106564A for ; Wed, 10 Dec 2008 19:58:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from server.baldwin.cx (bigknife-pt.tunnel.tserv9.chi1.ipv6.he.net [IPv6:2001:470:1f10:75::2]) by mx1.freebsd.org (Postfix) with ESMTP id 876408FC1D for ; Wed, 10 Dec 2008 19:58:02 +0000 (UTC) (envelope-from jhb@freebsd.org) Received: from localhost.corp.yahoo.com (john@localhost [IPv6:::1]) (authenticated bits=0) by server.baldwin.cx (8.14.3/8.14.3) with ESMTP id mBAJvori025274; Wed, 10 Dec 2008 14:57:56 -0500 (EST) (envelope-from jhb@freebsd.org) From: John Baldwin To: "Paul B. Mahol" Date: Wed, 10 Dec 2008 14:50:04 -0500 User-Agent: KMail/1.9.7 References: <200811191510.53793.jhb@FreeBSD.org> <200812091602.10850.jhb@freebsd.org> <3a142e750812100922m553be9c6sdcd81d98c81c7ab4@mail.gmail.com> In-Reply-To: <3a142e750812100922m553be9c6sdcd81d98c81c7ab4@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200812101450.04638.jhb@freebsd.org> X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (server.baldwin.cx [IPv6:::1]); Wed, 10 Dec 2008 14:57:56 -0500 (EST) X-Virus-Scanned: ClamAV 0.94.2/8744/Wed Dec 10 13:09:46 2008 on server.baldwin.cx X-Virus-Status: Clean X-Spam-Status: No, score=-2.6 required=4.2 tests=AWL,BAYES_00,NO_RELAYS autolearn=ham version=3.1.3 X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx Cc: freebsd-current@freebsd.org Subject: Re: [PATCH] MPSAFE/LOOKUP_SHARED cd9660 X-BeenThere: freebsd-current@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Discussions about the use of FreeBSD-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Dec 2008 19:58:03 -0000 On Wednesday 10 December 2008 12:22:43 pm Paul B. Mahol wrote: > On 12/9/08, John Baldwin wrote: > > The RRIP stuff is all done in cd9660_vget_internal() under an exclusive > > lock. > > It could be a property of the ISO image. "PX" holds permissions (owner, > > etc.). Do you get the same messages w/o the patch with the same ISO image / > > CD? > > > > -- > > John Baldwin > > > > I searched little for this message and found kern/63446 PR interesting comment: > > Caused by cd9660_vnops.c rev. 1.77. VOP_READDIR returns bogus > d_fileno, VFS_VGET on this value returns bogus vnode with zeroed attributes. > > I think that whatever locking is done is done wrong. That issue isn't a locking issue, it's an issue with VOP_READDIR() using a different meaning for i-node numbers than VFS_VGET(), and would happen regardless of any Giant or vnode locking. -- John Baldwin