Date: Fri, 25 Apr 2014 19:26:43 +0400 From: Boris Samorodov <bsam@passap.ru> To: Robert Backhaus <robbak@robbak.com> Cc: Stefan Bethke <stb@lassitu.de>, Freebsd_mailinglist_PORTS <freebsd-ports@freebsd.org> Subject: Re: foomatic-rip and foo2zjs Message-ID: <535A7EB3.5050108@passap.ru> In-Reply-To: <CABG_4j=HydwYgJizCCwsdQD7A3-D=64YkBsb10xTsRweU7Hvqw@mail.gmail.com> References: <338BD4B8-F25A-4CC5-A5FA-451C48BB5A5C@lassitu.de> <535A4E09.5000006@passap.ru> <CABG_4j=HydwYgJizCCwsdQD7A3-D=64YkBsb10xTsRweU7Hvqw@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
25.04.2014 17:20, Robert Backhaus пишет:
> I had the foomatic-rip problem today, but didn't think of this- even though
> I read it yesterday. I found it myself by running it in gdb, seeing it had
> something to do with logging, and turning off debug.
>
> Anyway, here's a backtrace: - but the pointed line, 1200, just looks wrong
> -
>
> int fd = mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, built - Yup,
> that's it. Here's the patch:
>
> --- foomaticrip.c.orig 2014-04-25 23:16:06.000000000 +1000
> +++ foomaticrip.c 2014-04-25 23:16:47.000000000 +1000
> @@ -1197,7 +1197,7 @@
> debug = 1;
>
> if (debug) {
> - int fd = mkstemp (LOG_FILE "-XXXXXX.log");
> + int fd = mkstemp ("LOG_FILE-XXXXXX.log");
> if (fd != -1)
> logh = fdopen(fd, "w");
> else
Thanks! I'll commit the patch to FreeBSD ports tree.
> Now to find who to send it to!
According to README one should use the site:
http://bugs.linux-foundation.org/
> (gdb) bt full
> #0 0x0000000800dae637 in snprintf () from /lib/libc.so.7
> No symbol table info available.
> #1 0x0000000800dae6e2 in mkstemp () from /lib/libc.so.7
> No symbol table info available.
> #2 0x00000000004046a1 in main (argc=1, argv=0x7fffffffe4a0) at
> foomaticrip.c:1200
> fd = 32767
> i = 6585344
> verbose = 0
> quiet = 0
> showdocs = 0
> str = 0x7fffffffe480 ""
> p = 0x0
> filename = 0x7fffffffe4b0 "$����\177"
> path = 0x80062e0cd
> "H\211D$`A[AZAYAX_^YZX\235H\215d$\020�\220\220\220\220\220\220\220\220\220\220H\213\227�"
> genpdqfile = (FILE *) 0x0
> ppdfh = (FILE *) 0x0
> tmp = '\0' <repeats 88 times>,
> "\212\031c\000\b\000\000\000\000\000\000\000\002\000\002\000�2�\000\b\000\000\000�����\177\000\000\000|d\000\b\000\000\000\000����\177\000\000�����\177\000\000\000\000\000\000\000\000\000\000�:c\000\b",
> '\0' <repeats 36 times>, "�b\000\b", '\0' <repeats 27 times>,
> "\2108�\000\b", '\0' <repeats 43 times>,
> "�Qd\000\b\000\000\000\200����\177\000\000p����\177\000\000\000\000\000\000\000\000\000\000p����\177\000\000W;c\000\b\000\000\000m\025@
> \000\000\000\000\000\004�\212\006\000\000\000\000��\217�\000\000\000\0000�d\000\b\000\000\000\001\000"...
> pstoraster = '\0' <repeats 255 times>
> havefilter = -1138054832
> havepstoraster = -511
> filelist = (dstr_t *) 0x801419040
> arglist = (list_t *) 0x801418040
>
> On 25 April 2014 21:59, Boris Samorodov <bsam@passap.ru> wrote:
>
>> 23.04.2014 00:23, Stefan Bethke пишет:
>>> Two quick observations I’m too lazy to file PRs for:
>>>
>>> foomatic-rip (from foomatic-filters-4.0.17) coredumps if you set debug:
>> 1 in /usr/local/etc/foomatic/filter.conf. I haven’t checked what is going
>> wrong specifically. It is possible to run foomatic-rip form the command
>> line with -v and with debug: 0, though.
>>
>> At a quick glance: there is a definition of preferred shell. It is
>> /bin/bash (commented out though). Did you try to define one? I'd
>> say that defining it to /usr/local/bin/bash may help.
>>
>>> foo2zjs-20140401 requires textproc/gsed, but it’s not a dependency of
>> the port. Not sure it really has to be gsed (instead of /usr/bin/sed), but
>> that is what it calls.
>>
>> Fixed, thanks!
>>
>> --
>> WBR, Boris Samorodov (bsam)
>> FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
>> _______________________________________________
>> freebsd-ports@freebsd.org mailing list
>> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
>> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
> _______________________________________________
> freebsd-ports@freebsd.org mailing list
> http://lists.freebsd.org/mailman/listinfo/freebsd-ports
> To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org"
>
--
WBR, Boris Samorodov (bsam)
FreeBSD Committer, http://www.FreeBSD.org The Power To Serve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?535A7EB3.5050108>