From owner-cvs-src@FreeBSD.ORG Sat May 20 15:36:11 2006 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 5BECD16A425; Sat, 20 May 2006 15:36:11 +0000 (UTC) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (repoman.freebsd.org [216.136.204.115]) by mx1.FreeBSD.org (Postfix) with ESMTP id 1658A43D48; Sat, 20 May 2006 15:36:11 +0000 (GMT) (envelope-from pjd@FreeBSD.org) Received: from repoman.freebsd.org (localhost [127.0.0.1]) by repoman.freebsd.org (8.13.6/8.13.6) with ESMTP id k4KFZbHs061258; Sat, 20 May 2006 15:35:37 GMT (envelope-from pjd@repoman.freebsd.org) Received: (from pjd@localhost) by repoman.freebsd.org (8.13.6/8.13.4/Submit) id k4KFZbmj061257; Sat, 20 May 2006 15:35:37 GMT (envelope-from pjd) Message-Id: <200605201535.k4KFZbmj061257@repoman.freebsd.org> From: Pawel Jakub Dawidek Date: Sat, 20 May 2006 15:35:37 +0000 (UTC) To: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org X-FreeBSD-CVS-Branch: HEAD Cc: Subject: cvs commit: src/sys/netipsec key.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 20 May 2006 15:36:11 -0000 pjd 2006-05-20 15:35:37 UTC FreeBSD src repository Modified files: sys/netipsec key.c Log: Prevent disappearing SAD entries by implementing MPsafe refcounting. "Why didn't he use SECASVAR_LOCK()/SECASVAR_UNLOCK() macros to synchronize access to the secasvar structure's fields?" one may ask. There were two reasons: 1. refcount(9) is faster then mutex(9) synchronization (one atomic operation instead of two). 2. Those macros are not used now at all, so at some point we may decide to remove them entirely. OK'ed by: gnn MFC after: 2 weeks Revision Changes Path 1.22 +33 -20 src/sys/netipsec/key.c