Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 Sep 2002 19:53:46 +0200
From:      Gary Jennejohn <garyj@jennejohn.org>
To:        Poul-Henning Kamp <phk@critter.freebsd.dk>
Cc:        isdn@freebsd.org
Subject:   Re: Found a cheap ISDN card today -- and a bug in -CURRENT 
Message-ID:  <200209101753.g8AHrkcF001670@peedub.jennejohn.org>
In-Reply-To: Your message of "Tue, 10 Sep 2002 18:41:37 %2B0200." <11464.1031676097@critter.freebsd.dk> 

next in thread | previous in thread | raw e-mail | index | archive | help
Poul-Henning Kamp writes:
> In message <200209101434.g8AEYb1Z001069@peedub.jennejohn.org>, Gary Jennejohn
>  w
> rites:
> >Poul-Henning Kamp writes:
> >> 
> >> I found a pre-owned PCI ISDN card for 3euro today, and promptly
> >> went back home to plug it into my -current machine:
> >> 
> >> Anyone interested ?
> >> 
> >
> >I think the driver is missing an mtx_initialize() of the mutex
> >in struct ifq. I added it to a bunch of drivers, but not to
> >layer1/itjc/i4b_itjc_pci.c. Try adding it and see what happens.
> 
> Bingo, thanks.
> 
> I'm surprised to see so much repeated code in all the layer1
> drivers, couldn't some of this be factored out to central code ?
> 

Yeah, a general cleanup wouldn't hurt in the least. But all this
stuff just "grew like topsy".

---
Gary Jennejohn / garyj@jennejohn.org gj@freebsd.org gj@denx.de


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-isdn" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200209101753.g8AHrkcF001670>