From owner-freebsd-hackers@FreeBSD.ORG  Mon Jun 13 12:44:33 2005
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
X-Original-To: freebsd-hackers@freebsd.org
Delivered-To: freebsd-hackers@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 33F3C16A41C
	for <freebsd-hackers@freebsd.org>; Mon, 13 Jun 2005 12:44:33 +0000 (GMT)
	(envelope-from joerg@britannica.bec.de)
Received: from hydra.bec.de (www.ostsee-abc.de [62.206.222.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP id DC16E43D1F
	for <freebsd-hackers@freebsd.org>; Mon, 13 Jun 2005 12:44:32 +0000 (GMT)
	(envelope-from joerg@britannica.bec.de)
Received: from britannica.bec.de (unknown [139.30.252.67])
	by hydra.bec.de (Postfix) with ESMTP id C033E35707
	for <freebsd-hackers@freebsd.org>;
	Mon, 13 Jun 2005 14:44:31 +0200 (CEST)
Received: by britannica.bec.de (Postfix, from userid 1001)
	id 8BCCD53ED; Mon, 13 Jun 2005 14:44:28 +0200 (CEST)
Date: Mon, 13 Jun 2005 14:44:27 +0200
From: Joerg Sonnenberger <joerg@britannica.bec.de>
To: freebsd-hackers@freebsd.org
Message-ID: <20050613124427.GD1343@britannica.bec.de>
Mail-Followup-To: freebsd-hackers@freebsd.org
References: <200506131412.38967.hselasky@c2i.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <200506131412.38967.hselasky@c2i.net>
User-Agent: Mutt/1.5.6i
Subject: Re: Obvious bug in /sys/i386/include/bus.h (was: bus_at386.h)
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 13 Jun 2005 12:44:33 -0000

On Mon, Jun 13, 2005 at 02:12:38PM +0200, Hans Petter Selasky wrote:
> This is equivalent to:
> 
> while(--count)
> {
>   /* I/O */
> }
> 
> which is obviously wrong, because it doesn't check for count equal to
> zero.

Why do you think it is a bug? It is part of the interface contract and
useful to avoid an unnecessary check in 99% of the cases.

Joerg