From owner-cvs-all@FreeBSD.ORG Wed Aug 6 15:33:12 2008 Return-Path: Delivered-To: cvs-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 6C51B1065675; Wed, 6 Aug 2008 15:33:12 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from ebb.errno.com (ebb.errno.com [69.12.149.25]) by mx1.freebsd.org (Postfix) with ESMTP id 3EC568FC21; Wed, 6 Aug 2008 15:33:12 +0000 (UTC) (envelope-from sam@freebsd.org) Received: from trouble.errno.com (trouble.errno.com [10.0.0.248]) (authenticated bits=0) by ebb.errno.com (8.13.6/8.12.6) with ESMTP id m76FXBQU059827 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Aug 2008 08:33:11 -0700 (PDT) (envelope-from sam@freebsd.org) Message-ID: <4899C437.3090506@freebsd.org> Date: Wed, 06 Aug 2008 08:33:11 -0700 From: Sam Leffler Organization: FreeBSD Project User-Agent: Thunderbird 2.0.0.9 (X11/20071125) MIME-Version: 1.0 To: Warner Losh References: <200808060734.m767Yoob077994@repoman.freebsd.org> In-Reply-To: <200808060734.m767Yoob077994@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-DCC-Rhyolite-Metrics: ebb.errno.com; whitelist Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/sys/dev/pccard pccard.c pccardvar.h X-BeenThere: cvs-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the entire tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 06 Aug 2008 15:33:12 -0000 Warner Losh wrote: > imp 2008-08-06 07:34:35 UTC > > FreeBSD src repository > > Modified files: > sys/dev/pccard pccard.c pccardvar.h > Log: > SVN rev 181342 on 2008-08-06 07:34:35Z by imp > > Unify the initial card probe/attach procedure with the kldload > procedure. There were some subtle differences before that could lead > to a variety of bugs, including resources being lost (in one case > forever). pccard_probe_and_attach_card does this now, and includes > comments about what's going on and why, since it isn't obvious from > the code. Please let me know if I've missed anything... > > Provide a new function called pccard_select_cfe that allows drivers to > select which configuration entry to use. This is needed for some > older pre-MFC standard cards with many functions that want to activate > all their functions by selecting alternative entries, or to work > around broken ones. pccard_select_cfe will migrate into the > pccard_if.m interface as its interface stabilizes to keep all the > pccard drivers from referencing any symbols in the pccard.ko module > directly. > > Are there any specific bugs this fixes? For example I have seen cases where ejecting a wireless card leaves the ifnet around. I also have a wireless card that does not probe (we've discsussed it; looks like an issue not powering on the socket). Sam