Date: Sat, 26 Apr 2014 08:16:11 +1000 From: Robert Backhaus <robbak@robbak.com> To: Boris Samorodov <bsam@passap.ru>, Stefan Bethke <stb@lassitu.de>, Robert Backhaus <robbak@robbak.com>, Freebsd_mailinglist_PORTS <freebsd-ports@freebsd.org> Subject: Re: foomatic-rip and foo2zjs Message-ID: <CABG_4jn0%2BTcfhz-4Wb_%2BS3ibw5ty5_-TWEjaBwSc5w6afZgYVw@mail.gmail.com> In-Reply-To: <85y4ytpdgx.fsf@iznogoud.viz> References: <338BD4B8-F25A-4CC5-A5FA-451C48BB5A5C@lassitu.de> <535A4E09.5000006@passap.ru> <CABG_4j=HydwYgJizCCwsdQD7A3-D=64YkBsb10xTsRweU7Hvqw@mail.gmail.com> <C30C335D-DCA2-4B26-A9E6-400361ABFBF4@lassitu.de> <535A8394.4060507@passap.ru> <85y4ytpdgx.fsf@iznogoud.viz>
next in thread | previous in thread | raw e-mail | index | archive | help
Yes, sorry. I got this wrong. The fix upstream has been to stop using mkstemp, and switch to using sprintf directly. http://bzr.linuxfoundation.org/loggerhead/openprinting/cups-filters/revision/7196 On 26 April 2014 02:41, Wolfgang Jenkner <wjenkner@inode.at> wrote: > On Fri, Apr 25 2014, Boris Samorodov wrote: > > >> Am 25.04.2014 um 15:20 schrieb Robert Backhaus <robbak@robbak.com>: > >> > >>> int fd = mkstemp (LOG_FILE "-XXXXXX.log"); - checked, edited, built - > Yup, that's it. Here's the patch: > > I think the problem is simply that mkstemp(3) requires an argument with > /trailing/ Xs, in accordance with POSIX[1]. So the upstream usage of it > seems to be wrong. > > [1] http://pubs.opengroup.org/onlinepubs/009695399/functions/mkstemp.html > _______________________________________________ > freebsd-ports@freebsd.org mailing list > http://lists.freebsd.org/mailman/listinfo/freebsd-ports > To unsubscribe, send any mail to "freebsd-ports-unsubscribe@freebsd.org" >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CABG_4jn0%2BTcfhz-4Wb_%2BS3ibw5ty5_-TWEjaBwSc5w6afZgYVw>