Date: Thu, 11 Oct 2007 11:38:12 -0700 From: Steve Kargl <sgk@troutmask.apl.washington.edu> To: Daniel Eischen <deischen@freebsd.org> Cc: freebsd-current@freebsd.org, bde@freebsd.org Subject: Re: Removing a symbol from Symbol.map? Message-ID: <20071011183812.GA24863@troutmask.apl.washington.edu> In-Reply-To: <Pine.GSO.4.64.0710111432060.16311@sea.ntplx.net> References: <20071011180815.GA23643@troutmask.apl.washington.edu> <Pine.GSO.4.64.0710111432060.16311@sea.ntplx.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Oct 11, 2007 at 02:34:35PM -0400, Daniel Eischen wrote: > On Thu, 11 Oct 2007, Steve Kargl wrote: > > >In my journey through the libm source code, I've discovered > >that msun/src/w_cabs.c contains a function named z_abs. This > >symbol appears in libm's Symbol.map, but z_abs has not prototype > >in any header file under /usr/include. Thus, it is namespace > >pollution that I'd like to remove. Do I simply remove z_abs from > >Symbol.map or is there more to it then this? > > Nope, no more to it than just removing it from the symbol > map. I certainly don't have any object to removing symbols > that don't belong there. It should be MFC'd to -7 before > release if it really shouldn't be there. If it doesn't > make it to -7, then we'll need to keep it as a compatibility > function forever. > > >PS: Yes, I know bde will probably object to removal of z_abs > >because of compatibility issues with fdlibm and the other *BSD. > I certainly believe that z_abs should be removed. I've cc'd bde to see if he has an objection. -- Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20071011183812.GA24863>