From owner-svn-ports-head@freebsd.org  Sun Jan 14 07:22:29 2018
Return-Path: <owner-svn-ports-head@freebsd.org>
Delivered-To: svn-ports-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id C56ABEA6238;
 Sun, 14 Jan 2018 07:22:29 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [96.47.72.132])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (Client CN "freefall.freebsd.org",
 Issuer "Let's Encrypt Authority X3" (verified OK))
 by mx1.freebsd.org (Postfix) with ESMTPS id A4E5D7065A;
 Sun, 14 Jan 2018 07:22:29 +0000 (UTC)
 (envelope-from danfe@freebsd.org)
Received: by freefall.freebsd.org (Postfix, from userid 1033)
 id ECA69723E; Sun, 14 Jan 2018 07:22:28 +0000 (UTC)
Date: Sun, 14 Jan 2018 07:22:28 +0000
From: Alexey Dokuchaev <danfe@FreeBSD.org>
To: Ben Woods <woodsb02@FreeBSD.org>
Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org,
 svn-ports-head@freebsd.org
Subject: Re: svn commit: r458949 - in head: devel/gvfs graphics/camera
 graphics/camerakit graphics/darktable graphics/digikam-kde4
 graphics/entangle graphics/eos-movrec graphics/flphoto
 graphics/fusefs-gphotofs...
Message-ID: <20180114072228.GA70693@FreeBSD.org>
References: <201801140123.w0E1NFK8056770@repo.freebsd.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <201801140123.w0E1NFK8056770@repo.freebsd.org>
User-Agent: Mutt/1.9.2 (2017-12-15)
X-BeenThere: svn-ports-head@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: SVN commit messages for the ports tree for head
 <svn-ports-head.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-ports-head>, 
 <mailto:svn-ports-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-ports-head/>
List-Post: <mailto:svn-ports-head@freebsd.org>
List-Help: <mailto:svn-ports-head-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-ports-head>,
 <mailto:svn-ports-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 14 Jan 2018 07:22:29 -0000

On Sun, Jan 14, 2018 at 01:23:15AM +0000, Ben Woods wrote:
> New Revision: 458949
> URL: https://svnweb.freebsd.org/changeset/ports/458949
> 
> Log:
>   graphics/libgphoto2: Update to 2.5.16
>   graphics/gphoto2: Update to 2.5.15
>   graphics/py-gphoto2: Update to 1.8.2
>   
> Modified: head/graphics/gphoto2/Makefile
> ...
> -USES=		gmake jpeg pkgconfig tar:bzip2
> +USES=		gmake jpeg localbase pkgconfig tar:bzip2
>  GNU_CONFIGURE=	yes
>  CONFIGURE_ENV=	POPT_CFLAGS="$$(pkg-config --cflags popt)" \
>  		POPT_LIBS="$$(pkg-config --libs popt)"
> @@ -30,8 +31,6 @@ AALIB_LIB_DEPENDS=	libaa.so:graphics/aalib
>  AALIB_CONFIGURE_WITH=	aalib
>  NLS_USES=		gettext
>  NLS_CONFIGURE_ENABLE=	nls
> -NLS_CPPFLAGS=		-I${LOCALBASE}/include
> -NLS_LDFLAGS=		-L${LOCALBASE}/lib

I don't understand this part: should't it be NLS_USES=localbase instead?

> Modified: head/graphics/libgphoto2/Makefile
> ...
> -USES=		gmake iconv libtool pkgconfig tar:bzip2
> +USES=		gmake iconv libtool localbase pkgconfig tar:bzip2
>  USE_CSTD=	gnu89
>  GNU_CONFIGURE=	yes
>  CONFIGURE_ENV=	LTDLINCL="-I${LOCALBASE}/include" \
> @@ -24,9 +25,6 @@ CONFIGURE_ENV=	LTDLINCL="-I${LOCALBASE}/include" \
>  		udevscriptdir=${WRKDIR}
>  INSTALL_TARGET=	install-strip
>  USE_LDCONFIG=	yes
> -
> -CPPFLAGS+=	-I${LOCALBASE}/include
> -LDFLAGS+=	-L${LOCALBASE}/lib

OK, here it's obvious, but the above change is not identical and thus
deserves an explanation.

./danfe