From owner-freebsd-ports-bugs@freebsd.org Tue May 18 17:46:04 2021 Return-Path: Delivered-To: freebsd-ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 7DB33652BAE for ; Tue, 18 May 2021 17:46:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mailman.nyi.freebsd.org (mailman.nyi.freebsd.org [IPv6:2610:1c1:1:606c::50:13]) by mx1.freebsd.org (Postfix) with ESMTP id 4Fl3MJ2xvjz3mkF for ; Tue, 18 May 2021 17:46:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: by mailman.nyi.freebsd.org (Postfix) id 63775652D56; Tue, 18 May 2021 17:46:04 +0000 (UTC) Delivered-To: ports-bugs@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 633ED652DA2 for ; Tue, 18 May 2021 17:46:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4Fl3MJ2HPtz3mkD for ; Tue, 18 May 2021 17:46:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org (kenobi.freebsd.org [IPv6:2610:1c1:1:606c::50:1d]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 37CC623B33 for ; Tue, 18 May 2021 17:46:04 +0000 (UTC) (envelope-from bugzilla-noreply@freebsd.org) Received: from kenobi.freebsd.org ([127.0.1.5]) by kenobi.freebsd.org (8.15.2/8.15.2) with ESMTP id 14IHk4w5002857 for ; Tue, 18 May 2021 17:46:04 GMT (envelope-from bugzilla-noreply@freebsd.org) Received: (from www@localhost) by kenobi.freebsd.org (8.15.2/8.15.2/Submit) id 14IHk4Mx002856 for ports-bugs@FreeBSD.org; Tue, 18 May 2021 17:46:04 GMT (envelope-from bugzilla-noreply@freebsd.org) X-Authentication-Warning: kenobi.freebsd.org: www set sender to bugzilla-noreply@freebsd.org using -f From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 255670] Mk/Keywords/sample.ucl: Deleting any configuration files automatically is a bug Date: Tue, 18 May 2021 17:46:04 +0000 X-Bugzilla-Reason: CC X-Bugzilla-Type: changed X-Bugzilla-Watch-Reason: None X-Bugzilla-Product: Ports & Packages X-Bugzilla-Component: Ports Framework X-Bugzilla-Version: Latest X-Bugzilla-Keywords: needs-qa X-Bugzilla-Severity: Affects Some People X-Bugzilla-Who: dave@jetcafe.org X-Bugzilla-Status: Open X-Bugzilla-Resolution: X-Bugzilla-Priority: --- X-Bugzilla-Assigned-To: portmgr@FreeBSD.org X-Bugzilla-Flags: maintainer-feedback? X-Bugzilla-Changed-Fields: Message-ID: In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/ Auto-Submitted: auto-generated MIME-Version: 1.0 X-BeenThere: freebsd-ports-bugs@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Ports bug reports List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 May 2021 17:46:04 -0000 https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D255670 --- Comment #5 from dave@jetcafe.org --- (In reply to Adam Weinberger from comment #4) > they should be recreated immediately when the package is upgraded/reinsta= lled I have not observed this behavior consistently. Instead, with recent upgrad= es (1.14.6 -> 1.16.3) I've observed that in some cases the -dist files are not automatically installed (leaving no file in it's place), and in others they are. Note that this will likely be a separate (but related) issue, as I do = not have enough actionable data to file a bug report yet (nor do I know if the inconsistent behavior is, in fact, a bug or something else).=20 Still, this technically unrelated behavior is, in fact, the stimulus for my change request. Not installing -dist files is somewhat expected given that = they are -dist files, but not expected by the person who wrote the nginx.conf fi= le which includes them. I'm unclear why the current behavior of pre-deinstall-= lua contains any notion of os.remove() ... I find this to be an unsafe practice. As far as I can tell, the mechanism in question is with the @sample keyword= in the pkg-plist file. However, maybe this mechanism is insufficient or perhap= s I am naive about my understanding of this idea? There are two cases I can see happening: 1) The port needs those files installed even if they are samples 2) The port does not need those files installed.=20 The sample keyword appears to assume (2), not (1). Neither case implies deleting what is already there.=20 Do you know of a way to increase verbosity of pkg in a way that sheds more light on this and related issues? --=20 You are receiving this mail because: You are on the CC list for the bug.=