Date: Tue, 02 Oct 2018 16:11:12 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 231770] databases/sqlite3: Add ICU flavor Message-ID: <bug-231770-7788-SD5YrtqMan@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-231770-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-231770-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D231770 --- Comment #2 from Matt <fsbruva@yahoo.com> --- See: https://www.freebsd.org/doc/en/books/porters-handbook/flavors-using.ht= ml. Look especially example 7.3, where flavors directly control build variables, rather than port OPTIONS. I looked at your patch, but cannot test until tonight. I believe using the OPTIONS_DEFAULT will permit the proper package creation install via 'pkg'. However, I believe this method can be broken by the user if built from the ports tree. This is because regardless of the OPTIONS_DEFAULT value(s), the user can de-select the ICU option during 'make config'. In this case, the resulting package will have the -icu suffix once installed, but SQLite won't actually be linked against ICU. This will lead to unacceptable ambiguity.=20 This is why my patch completely overrides the OPTIONS list, and makes the I= CU dependency non-optional for the -icu flavor. I will test tonight, and revis= e my patch to include your proposed "mini" flavor. --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-231770-7788-SD5YrtqMan>