Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 10 Jul 2005 20:16:42 -0700
From:      Sam Leffler <sam@errno.com>
To:        src-committers@FreeBSD.org
Cc:        cvs-src@FreeBSD.org, cvs-all@FreeBSD.org
Subject:   Re: cvs commit: src/sys/net80211 ieee80211_crypto_ccmp.c
Message-ID:  <42D1E49A.5040508@errno.com>
In-Reply-To: <200507110306.j6B36NI3058528@repoman.freebsd.org>
References:  <200507110306.j6B36NI3058528@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Sam Leffler wrote:
> sam         2005-07-11 03:06:23 UTC
> 
>   FreeBSD src repository
> 
>   Modified files:
>     sys/net80211         ieee80211_crypto_ccmp.c 
>   Log:
>   Handle encrypt of arbitarily fragmented mbuf chains: previously
>   we bailed if we couldn't collect the 16-bytes of data required
>   for an aes block cipher in 2 mbufs; now we deal with it.  While
>   here make space accounting signed so a sanity check does the
>   right thing for malformed mbuf chains.

Note that the decrypt path does not need this complexity because rx'd 
frames are assumed to not have arbitrary fragmentation (typically data 
is dma'd into clusters or multiple fully-packed mbufs).

Also I think a better solution is to defrag/repack the mbuf chain to 
have 16-byte alignment (except for the last mbuf) so we don't need to do 
s/g of data on the fly.

With this change I'm able to run extensive tcp netperf tests over ural 
cards and 5211 ath cards using wpa w/ ccmp as the unicast cipher.

	Sam



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?42D1E49A.5040508>