From owner-cvs-src@FreeBSD.ORG Mon Jul 11 03:11:43 2005 Return-Path: X-Original-To: cvs-src@FreeBSD.org Delivered-To: cvs-src@FreeBSD.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 4696E16A41C; Mon, 11 Jul 2005 03:11:43 +0000 (GMT) (envelope-from sam@errno.com) Received: from ebb.errno.com (ebb.errno.com [66.127.85.87]) by mx1.FreeBSD.org (Postfix) with ESMTP id F14F243D46; Mon, 11 Jul 2005 03:11:42 +0000 (GMT) (envelope-from sam@errno.com) Received: from [66.127.85.91] ([66.127.85.91]) (authenticated bits=0) by ebb.errno.com (8.12.9/8.12.6) with ESMTP id j6B3Bcms071668 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Sun, 10 Jul 2005 20:11:40 -0700 (PDT) (envelope-from sam@errno.com) Message-ID: <42D1E49A.5040508@errno.com> Date: Sun, 10 Jul 2005 20:16:42 -0700 From: Sam Leffler User-Agent: Mozilla Thunderbird 1.0.2 (X11/20050327) X-Accept-Language: en-us, en MIME-Version: 1.0 To: src-committers@FreeBSD.org References: <200507110306.j6B36NI3058528@repoman.freebsd.org> In-Reply-To: <200507110306.j6B36NI3058528@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/net80211 ieee80211_crypto_ccmp.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jul 2005 03:11:43 -0000 Sam Leffler wrote: > sam 2005-07-11 03:06:23 UTC > > FreeBSD src repository > > Modified files: > sys/net80211 ieee80211_crypto_ccmp.c > Log: > Handle encrypt of arbitarily fragmented mbuf chains: previously > we bailed if we couldn't collect the 16-bytes of data required > for an aes block cipher in 2 mbufs; now we deal with it. While > here make space accounting signed so a sanity check does the > right thing for malformed mbuf chains. Note that the decrypt path does not need this complexity because rx'd frames are assumed to not have arbitrary fragmentation (typically data is dma'd into clusters or multiple fully-packed mbufs). Also I think a better solution is to defrag/repack the mbuf chain to have 16-byte alignment (except for the last mbuf) so we don't need to do s/g of data on the fly. With this change I'm able to run extensive tcp netperf tests over ural cards and 5211 ath cards using wpa w/ ccmp as the unicast cipher. Sam