From owner-freebsd-i386@FreeBSD.ORG Tue Oct 18 09:33:56 2005 Return-Path: X-Original-To: freebsd-i386@hub.freebsd.org Delivered-To: freebsd-i386@hub.freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 3781316A41F for ; Tue, 18 Oct 2005 09:33:56 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by mx1.FreeBSD.org (Postfix) with ESMTP id 004A843D49 for ; Tue, 18 Oct 2005 09:33:55 +0000 (GMT) (envelope-from gnats@FreeBSD.org) Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1]) by freefall.freebsd.org (8.13.3/8.13.3) with ESMTP id j9I9Xtc4026285 for ; Tue, 18 Oct 2005 09:33:55 GMT (envelope-from gnats@freefall.freebsd.org) Received: (from gnats@localhost) by freefall.freebsd.org (8.13.3/8.13.1/Submit) id j9I9XtQu026284; Tue, 18 Oct 2005 09:33:55 GMT (envelope-from gnats) Date: Tue, 18 Oct 2005 09:33:55 GMT Message-Id: <200510180933.j9I9XtQu026284@freefall.freebsd.org> To: freebsd-i386@FreeBSD.org From: HASHI Hiroaki Cc: Subject: Re: i386/87208: /dev/cuad[0/1] bad file descriptor error during mgetty read X-BeenThere: freebsd-i386@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: HASHI Hiroaki List-Id: I386-specific issues for FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 18 Oct 2005 09:33:56 -0000 The following reply was made to PR i386/87208; it has been noted by GNATS. From: HASHI Hiroaki To: bug-followup@FreeBSD.org, norbert@feu-nrmf.ph Cc: Subject: Re: i386/87208: /dev/cuad[0/1] bad file descriptor error during mgetty read Date: Tue, 18 Oct 2005 18:30:58 +0900 (JST) In this case, mgetty open a /dev/cuad? and dup(2) to stdin. int fd; fd = open(devname, O_RDWR | O_NDELAY | O_NOCTTY ); /* make new fd == stdin if it isn't already */ if (fd > 0) { (void) close(0); ---> if (dup(fd) != 0) { lprintf( L_FATAL, "mod: cannot make %s stdin", devname ); return ERROR; } } Bad dup() was not return descriptor 0. Is this a dup(3)'s bug? (or imcompatible change?) Workaround: mgetty use dup2(3) instead of use dup(3). dup2(fd, 0) . . dup2(0, 1) . . dup2(0, 2) . .