From owner-svn-ports-all@freebsd.org Tue Jan 22 23:19:48 2019 Return-Path: Delivered-To: svn-ports-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 948BE14B2D6F; Tue, 22 Jan 2019 23:19:48 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 369C375A1B; Tue, 22 Jan 2019 23:19:48 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Received: from tommy.madpilot.net (unknown [87.13.153.156]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) (Authenticated sender: madpilot/mail) by smtp.freebsd.org (Postfix) with ESMTPSA id 8DFF2E059; Tue, 22 Jan 2019 23:19:47 +0000 (UTC) (envelope-from madpilot@FreeBSD.org) Subject: Re: svn commit: r490973 - head/deskutils/xfce4-volumed To: =?UTF-8?Q?T=c4=b3l_Coosemans?= Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org References: <201901221850.x0MIojFp085050@repo.freebsd.org> <20190122203337.120c1bad@kalimero.tijl.coosemans.org> From: Guido Falsi Openpgp: preference=signencrypt Autocrypt: addr=madpilot@FreeBSD.org; prefer-encrypt=mutual; keydata= mQENBE+G+l0BCADi/WBQ0aRJfnE7LBPsM0G3m/m3Yx7OPu4iYFvS84xawmRHtCNjWIntsxuX fptkmEo3Rsw816WUrek8dxoUAYdHd+EcpBcnnDzfDH5LW/TZ4gbrFezrHPdRp7wdxi23GN80 qPwHEwXuF0X4Wy5V0OO8B6VT/nA0ADYnBDhXS52HGIJ/GCUjgqJn+phDTdCFLvrSFdmgx4Wl c0W5Z1p5cmDF9l8L/hc959AeyNf7I9dXnjekGM9gVv7UDUYzCifR3U8T0fnfdMmS8NeI9NC+ wuREpRO4lKOkTnj9TtQJRiptlhcHQiAlG1cFqs7EQo57Tqq6cxD1FycZJLuC32bGbgalABEB AAG0Ikd1aWRvIEZhbHNpIDxtYWRwaWxvdEBGcmVlQlNELm9yZz6JATYEEwEIACACGwMCHgEC F4AFAlLvzwUFCwkIBwMFFQoJCAsEFgIDAQAKCRAa5oYOVsvSk6EzCAC4ovSo6XF4x0spuKmp RzVuZ5ywqCJAfRIrJHpW8HjSPkcUYwmXVOE3zjul9j2C2eHPPGobEDN5FqovAtzb7HdYGGcU aUdhDApUMMRVkzflwb23C/CI1RBcZxjC0noajSKgbIHx4+Afg6CFMgpngq+NJwEaaVrKlYzq G+KcfeVKAdwlWHJOgQJIEylUtwtBqXx/iJDrGwKO5A6a1uSEZrZfuwjSh8cBqoUfIwLZUIFE HBjHa8pUkp8mWx7JaZ19vBF6pDpPVZSoLSg8stWd1DPesn/qySYgtSGSY6hpWABVF98HRsBG +VXlHtqCaB0j0cGCDhCpHQUI10oGGc8k4zcvuQINBFMQe0EBEAChYaw3HqD3SvyBw0pqI+kk GIrLzO1XYXJXkuxPQ6BAFbe8jG3+h22zFU02OnJL8E1kLLMsCwVzVasYHOFiyY831IYHn/lh O+TN/lhWJTlUCxmWP8xFYJmta2mJzhzQDs3hyw5hF422T+rxgHg8gWxn0D6RO6hmGe7m3k91 8EDvj5JXAq7zj49mT3AMRjUtsVVPy8zjagqyaizCUiHAnbG4kj+BuT5wxR7TKJGk2OjhK/Dh EHzgHq4XB1Gv8+1LvGLZmqih/kBpBP1hIGkakok579CTkw/g8XoWqr6Cjz2fvtjaQmTBwdou gP8Yn5kMBIiIxF7XLngUc5DVEJMYamcktd0q4aHC/cnbWlTwc2WrQBI1AwxCZgDC1RbOOan8 oTIjWqRyaNp9zFvxOaJqgrxJA3Vl/3p9z+witk3pnmg4ITLIJDSmsf89MDaOVGQpDjzs9MaT YlIpTlW5Lns2WTYOue+NanntpX14UCGmeusk+4aYXPzf89zyALS3s3uLtVUdhFwLmdrFgHZS gjU5STLGlP8e9AVddVnf8qZ1czOvHX3UCCAI9YjBQA/5VxpRFJil4OTr9lUA5U57UKGpwmKw IPvArbT8468nYC2Rat4a7UJn3NLHucr9Vh0uvfgbFDhtPUb72sFA2cVI1tfZMnjfUx2jUYKM N5ErgK1Kes0piQARAQABiQEfBBgBCAAJBQJTEHtBAhsMAAoJEBrmhg5Wy9KTDecIAOGwpF/6 sBFQtOk6HkegtqbrZklkDIKQ2qq7+uR7m6PkBpoNj+HsE2EEOIOqGFktN6h8alVVoSs+xY36 1fnR/Kmwi30oCHL3QYWu2shmVa7IrjCyhm8N+n3JpGT6Ugznx3D9Fx/GfrvQlo9MVJE8QJWf +4uoGElKRtiVjbXZhP1/FVRMl7rAi8MtCtASOtAP+HUUyF9wuECqyd2W1F3oM+9Mp4x3/pUD GfSGSgEqETLkuRaMz0Iemm75sGRD3X+SPa4lBJc7x66ifAcdLdz7o3aLYfsjR6Zwca7TvC5E Ha0OfD9EsHGiF9909lPaRvG4buWFUfPBUPDkNHBLDwaQ53I= Message-ID: Date: Wed, 23 Jan 2019 00:19:44 +0100 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190122203337.120c1bad@kalimero.tijl.coosemans.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 369C375A1B X-Spamd-Bar: ------ Authentication-Results: mx1.freebsd.org X-Spamd-Result: default: False [-6.95 / 15.00]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; REPLY(-4.00)[]; NEURAL_HAM_SHORT(-0.95)[-0.953,0] X-BeenThere: svn-ports-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: SVN commit messages for the ports tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 22 Jan 2019 23:19:48 -0000 On 22/01/19 20:33, Tijl Coosemans wrote: > On Tue, 22 Jan 2019 18:50:45 +0000 (UTC) Guido Falsi wrote: >> Author: madpilot >> Date: Tue Jan 22 18:50:45 2019 >> New Revision: 490973 >> URL: https://svnweb.freebsd.org/changeset/ports/490973 >> >> Log: >> - Add missing dependencies >> - Sort lists >> - Fix portlint warnings >> >> PR: 235128 >> Submitted by: myself >> Approved by: Sergey V. Dyatko (Maintainer) >> >> Modified: >> head/deskutils/xfce4-volumed/Makefile >> >> Modified: head/deskutils/xfce4-volumed/Makefile >> ============================================================================== >> --- head/deskutils/xfce4-volumed/Makefile Tue Jan 22 18:48:38 2019 (r490972) >> +++ head/deskutils/xfce4-volumed/Makefile Tue Jan 22 18:50:45 2019 (r490973) >> @@ -3,7 +3,7 @@ >> >> PORTNAME= xfce4-volumed >> PORTVERSION= 0.1.13 >> -PORTREVISION= 2 >> +PORTREVISION= 3 >> CATEGORIES= deskutils xfce >> MASTER_SITES= XFCE/src/apps/${PORTNAME}/${PORTVERSION:R} >> DIST_SUBDIR= xfce4 >> @@ -13,13 +13,18 @@ COMMENT= Volume management daemon for the Xfce desktop >> >> LICENSE= GPLv3 >> >> -LIB_DEPENDS= libnotify.so:devel/libnotify \ >> - libkeybinder.so:x11/keybinder >> +LIB_DEPENDS= libdbus-glib-1.so:devel/dbus-glib \ >> + libdbus-1.so:devel/dbus \ >> + libnotify.so:devel/libnotify \ >> + libkeybinder.so:x11/keybinder \ >> + libfontconfig.so:x11-fonts/fontconfig \ >> + libfreetype.so:print/freetype2 >> >> -USES= pkgconfig gmake xfce tar:bzip2 >> -GNU_CONFIGURE= yes >> -USE_GNOME= glib20 >> +USES= gmake gnome pkgconfig tar:bzip2 xfce >> +USE_GNOME= atk cairo gdkpixbuf2 glib20 gtk20 libxml2 pango > > These dependencies need to be added to Mk/Uses/gnome.mk instead of every > single gtk port. They are caused by > /usr/local/libdata/pkgconfig/gtk+-x11-2.0.pc and > /usr/local/libdata/pkgconfig/pangoft2.pc. > You definitely have a point here, but I was working only on the xfce ports. Most xfce ports already had these registered. I thought it was correct to align them all. -- Guido Falsi