Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 5 Aug 2015 14:21:53 +1000 (EST)
From:      Bruce Evans <brde@optusnet.com.au>
To:        Ed Schouten <ed@nuxi.nl>
Cc:        Warner Losh <imp@bsdimp.com>, Bruce Evans <brde@optusnet.com.au>,  John-Mark Gurney <jmg@freebsd.org>,  src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org,  svn-src-head@freebsd.org
Subject:   Re: svn commit: r286103 - head/share/man/man9
Message-ID:  <20150805135323.X1025@besplex.bde.org>
In-Reply-To: <CABh_MKnevbQHf4O=Ynj8Yv1FW7HyCKGTuHHJof5Sa=OaqtgzUQ@mail.gmail.com>
References:  <201507310328.t6V3S3LC087650@repo.freebsd.org> <20150731152253.Y1843@besplex.bde.org> <CABh_MKmneTxb=djUdmSYPM2dnwuy1AzpNrvsCnPN0-NkvqsEXg@mail.gmail.com> <2B9D4FA9-FDB2-405D-B8C0-BE9918941159@bsdimp.com> <CABh_MKnevbQHf4O=Ynj8Yv1FW7HyCKGTuHHJof5Sa=OaqtgzUQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, 4 Aug 2015, Ed Schouten wrote:

> 2015-08-04 20:23 GMT+02:00 Warner Losh <imp@bsdimp.com>:
>> There=E2=80=99s at least one compiler in common use that warns about
>>
>> extern int fred[1];
>> extern int fred[1];
>>
>> being a repeated declaration (despite being legal C).
>
> Would you happen to know which one that is?

All non-broken compilers warn about this when directed to do so by
-Wredundant-decls.  I think -Wno-system-headers turns this off, but
we use -Wsystem-headers so as to see bugs in our system headers.

clang is broken and doesn't even warn that it ignores -Wredundant-decls.

We use -Wredundant-decls at WARNS >=3D 6.  We used to use it always in the
kernel, but now we turn it and most other warnings off in cddl code.

We use -Wsystem-headers at WARNS >=3D 1.  We don't use it explicitly in
the kernel.  That might be a bug.  The kernel uses nonstandard include
paths, but so does userland for bootstrapping and cross compiling.
The kernel also uses -nostdinc and that should kill any idea that the
kernel has about which headers are system ones.  Makeworld doesn't
seem to use -nostdinc.  That might be another bug.  It uses lots of
-I paths, but there is still a possibility of getting host headers
mixed with target ones.  cddl has different messes for -nostdinc.  It
seems to duplicate it together with spamming CFLAGS with lots of -I's.

Bruce
From owner-svn-src-head@freebsd.org  Wed Aug  5 04:39:48 2015
Return-Path: <owner-svn-src-head@freebsd.org>
Delivered-To: svn-src-head@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 344629B26BE;
 Wed,  5 Aug 2015 04:39:48 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1])
 (using TLSv1 with cipher DHE-RSA-CAMELLIA256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id B91F41954;
 Wed,  5 Aug 2015 04:39:47 +0000 (UTC)
 (envelope-from kostikbel@gmail.com)
Received: from tom.home (kostik@localhost [127.0.0.1])
 by kib.kiev.ua (8.15.2/8.15.2) with ESMTPS id t754dhV0024692
 (version=TLSv1 cipher=DHE-RSA-CAMELLIA256-SHA bits=256 verify=NO);
 Wed, 5 Aug 2015 07:39:43 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
DKIM-Filter: OpenDKIM Filter v2.9.2 kib.kiev.ua t754dhV0024692
Received: (from kostik@localhost)
 by tom.home (8.15.2/8.15.2/Submit) id t754dh3U024691;
 Wed, 5 Aug 2015 07:39:43 +0300 (EEST)
 (envelope-from kostikbel@gmail.com)
X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com
 using -f
Date: Wed, 5 Aug 2015 07:39:43 +0300
From: Konstantin Belousov <kostikbel@gmail.com>
To: Jung-uk Kim <jkim@FreeBSD.org>
Cc: Bruce Evans <brde@optusnet.com.au>, src-committers@freebsd.org,
 svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject: Re: svn commit: r286265 - head/sys/x86/include
Message-ID: <20150805043943.GV2072@kib.kiev.ua>
References: <201508040011.t740BeD3088014@repo.freebsd.org>
 <20150804041458.GF2072@kib.kiev.ua>
 <20150804143613.H896@besplex.bde.org>
 <55C10CDA.4070006@FreeBSD.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <55C10CDA.4070006@FreeBSD.org>
User-Agent: Mutt/1.5.23 (2014-03-12)
X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00,
 DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no
 autolearn_force=no version=3.4.1
X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on tom.home
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.20
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head/>;
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 05 Aug 2015 04:39:48 -0000

On Tue, Aug 04, 2015 at 03:04:58PM -0400, Jung-uk Kim wrote:
> Done.  I was not really interested in API compatibility.  FYI, "Figure
> 3.34: va_list Type Declaration" defines the structure like this:
> 
> 	typedef struct {
> 		unsigned int gp_offset;
> 		unsigned int fp_offset;
> 		void *overflow_arg_area;
> 		void *reg_save_area;
> 	} va_list[1];

Thank you for the pointer. I read this long time ago as an optional
advice for the possible implementation and not as the ABI requirement,
so I forgot about it.



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20150805135323.X1025>