Date: Thu, 02 Oct 2014 07:05:46 +0000 From: bugzilla-noreply@freebsd.org To: freebsd-ports-bugs@FreeBSD.org Subject: [Bug 194086] New: [patch] net/GeoIP: geoipupdate.sh still don't update file atomically Message-ID: <bug-194086-13@https.bugs.freebsd.org/bugzilla/>
next in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=194086 Bug ID: 194086 Summary: [patch] net/GeoIP: geoipupdate.sh still don't update file atomically Product: Ports Tree Version: Latest Hardware: Any OS: Any Status: Needs Triage Severity: Affects Many People Priority: --- Component: Individual Port(s) Assignee: adamw@FreeBSD.org Reporter: freebsd-bug-report-yf@yf.bsdclub.org Assignee: adamw@FreeBSD.org Flags: maintainer-feedback?(adamw@FreeBSD.org) Created attachment 147901 --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=147901&action=edit patch to fix problem, create temp dir on same device geoipupdate.sh don't update GeoIP.dat and GeoIPv6.dat atomically when $TEMPDIR and %%DATADIR%% are not on the same device. mv(1) first try to rename(2), which is atomically replace the file, but if failed becase of cross devices, then copy file without any lock mechanism. It is why working file should be placed under the same directory. --- Comment #1 from Bugzilla Automation <bugzilla@FreeBSD.org> --- Auto-assigned to maintainer adamw@FreeBSD.org -- You are receiving this mail because: You are the assignee for the bug.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-194086-13>