From owner-cvs-src@FreeBSD.ORG Fri Oct 26 19:22:26 2007 Return-Path: Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 4F9BC16A417; Fri, 26 Oct 2007 19:22:26 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from pooker.samsco.org (pooker.samsco.org [168.103.85.57]) by mx1.freebsd.org (Postfix) with ESMTP id B992413C4AA; Fri, 26 Oct 2007 19:22:25 +0000 (UTC) (envelope-from scottl@samsco.org) Received: from phobos.samsco.home (phobos.samsco.home [192.168.254.11]) (authenticated bits=0) by pooker.samsco.org (8.13.8/8.13.8) with ESMTP id l9QJLw6o070594; Fri, 26 Oct 2007 13:21:58 -0600 (MDT) (envelope-from scottl@samsco.org) Message-ID: <47223E42.4090905@samsco.org> Date: Fri, 26 Oct 2007 13:21:38 -0600 From: Scott Long User-Agent: Mozilla/5.0 (Macintosh; U; Intel Mac OS X; en-US; rv:1.8.1.6) Gecko/20070802 SeaMonkey/1.1.4 MIME-Version: 1.0 To: Andrey Chernov , Rong-en Fan , Scott Long , John Baldwin , src-committers@freebsd.org, d@delphij.net, cvs-all@freebsd.org, Robert Watson , cvs-src@freebsd.org References: <200710150951.l9F9pUm7026506@repoman.freebsd.org> <20071025233536.B99770@fledge.watson.org> <472120E8.90504@samsco.org> <200710261144.34645.jhb@freebsd.org> <472217C2.8020800@samsco.org> <6eb82e0710260954m73b3f17bq2c72a4cdb597640e@mail.gmail.com> <20071026190039.GB38843@nagual.pp.ru> In-Reply-To: <20071026190039.GB38843@nagual.pp.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by milter-greylist-2.0.2 (pooker.samsco.org [168.103.85.57]); Fri, 26 Oct 2007 13:21:58 -0600 (MDT) X-Spam-Status: No, score=-1.4 required=5.5 tests=ALL_TRUSTED autolearn=failed version=3.1.8 X-Spam-Checker-Version: SpamAssassin 3.1.8 (2007-02-13) on pooker.samsco.org Cc: Subject: Re: cvs commit: src/lib/libc/locale utf8.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Oct 2007 19:22:26 -0000 Andrey Chernov wrote: > On Sat, Oct 27, 2007 at 12:54:21AM +0800, Rong-en Fan wrote: >> As for RELENG_7 and HEAD, I'm not 100% sure whether we should restore >> the compatibility as 1) 7.0 is not released yet, 2) we don't promise >> anything in >> HEAD branch. However, if most people think get rid of inline stuffs and >> have libc compatibility are nice, then we do the same for those two branches. > > Although standard permits functions only, I object against permanent > removing inlines from ctype. Almost every system have them as macros or > inlines and not as function calls, and it is for reason. Ctype functions > are very inside-loop-intensive, and not speeding them up may slowdown apps > which do intensive text processing. > > In the case we trade forward compatibility for speed for 6x, may be, I > don't have opinion here. > RELENG_6 is what I'm most concerned about, so thank you for compromising on it. It's unfortunate that turmoil was created in HEAD and RELENG_7, but it looks like it was unavoidable given our standard practices of MFC oriented changes. I do think that this all could have been planned and executed better so that surprises and changes like this weren't needed. But, live and learn. Thanks for working on it. Scott