From owner-cvs-all Sun Feb 11 15:46:59 2001 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id 021A237B401; Sun, 11 Feb 2001 15:46:55 -0800 (PST) Received: (from mjacob@localhost) by freefall.freebsd.org (8.11.1/8.11.1) id f1BNks768335; Sun, 11 Feb 2001 15:46:54 -0800 (PST) (envelope-from mjacob) Message-Id: <200102112346.f1BNks768335@freefall.freebsd.org> From: Matt Jacob Date: Sun, 11 Feb 2001 15:46:54 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/cam/scsi scsi_all.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG mjacob 2001/02/11 15:46:54 PST Modified files: sys/cam/scsi scsi_all.c Log: 1. The key SSD_KEY_RECOVERED_ERROR is not an error at all and should not be retried. It is an indication that there was an error that was corrected during the execution of the command. This is per ANSI SCSI2 spec. It's possible that these should also be noted to the console (as indicative, perhaps, of growing media defect lists in drives), but the default of printing errors out if bootverbose in this case is probably enough. Also, there'd been a missing ERESTART for that clause anyway. 2. If you have an ABORTED COMMAND, it's almost invariably a SCSI parity error. You should never be silent about these since users should do something about this if it occurs (moving that power cord *away* from the SCSI cable is always a good first start). This should print irrespective of bootverbose because it's an actual real error even if we retry a transmission. Reviewed by: audit@freebsd.org, gibbs@freebsd.org Revision Changes Path 1.18 +16 -8 src/sys/cam/scsi/scsi_all.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message