Date: Tue, 16 Apr 2002 20:47:26 -0400 (EDT) From: John Baldwin <jhb@FreeBSD.org> To: Poul-Henning Kamp <phk@critter.freebsd.dk> Cc: Steve Kargl <sgk@troutmask.apl.washington.edu>, cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, "Greg 'groggy' Lehey" <grog@FreeBSD.ORG>, Jeroen Ruigrok/asmodai <asmodai@wxs.nl>, obrien@FreeBSD.ORG Subject: Re: cvs commit: src/sbin/savecore savecore.c Message-ID: <XFMail.20020416204726.jhb@FreeBSD.org> In-Reply-To: <65355.1018940734@critter.freebsd.dk>
next in thread | previous in thread | raw e-mail | index | archive | help
On 16-Apr-2002 Poul-Henning Kamp wrote: > In message <20020415235849.A4416@dragon.nuxi.com>, "David O'Brien" writes: >>On Sun, Apr 14, 2002 at 09:03:04AM -0700, Steve Kargl wrote: >>> Marcel's savecore creates 2 files "md5.info" and "md5.core" where >>> "md5" is determined from the md5 checksum of the kernel dump header >>> struct. >> >>Actually that was PHK's. >> >>PHK, what was your motivation in changing the saved core filename? > > I wanted to avoid having to open the disk device in RW mode, so the > best way to find out if we had already saved a dump was to make > a hash of the header and look for that. Hmm, I really don't like that. I find the current scheme of vmcore.XX and kernel.XX to be rather intuitive. For one thing, it makes it very easy to see which dump is the most recent. Why can't you save the hash of the header in the core file or something but still keep the filenames usable. Surely we don't have to give up useful filenames for this. -- John Baldwin <jhb@FreeBSD.org> <>< http://www.FreeBSD.org/~jhb/ "Power Users Use the Power to Serve!" - http://www.FreeBSD.org/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?XFMail.20020416204726.jhb>