Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 26 Oct 2011 12:44:51 -0700
From:      Doug Barton <dougb@FreeBSD.org>
To:        Sunpoet Po-Chuan Hsieh <sunpoet@FreeBSD.org>
Cc:        Olivier Cochard-Labbe <olivier@cochard.me>, cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject:   Re: cvs commit: ports/www/shellinabox Makefile ports/www/shellinabox/files shellinaboxd.in
Message-ID:  <4EA86333.8090804@FreeBSD.org>
In-Reply-To: <201110261620.p9QGK0vV010389@repoman.freebsd.org>
References:  <201110261620.p9QGK0vV010389@repoman.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 10/26/2011 09:20, Sunpoet Po-Chuan Hsieh wrote:
> sunpoet     2011-10-26 16:20:00 UTC
> 
>   FreeBSD ports repository
> 
>   Modified files:
>     www/shellinabox      Makefile 
>     www/shellinabox/files shellinaboxd.in 
>   Log:
>   - Unset shellinaboxd_user and shellinaboxd_group at the end of rc script to
>     avoid unnecessary su(1) initiated by rc.subr

I solved this in the named rc.d script by using _uid, which is not
special to rc.subr; instead of _user, which is. Also, the following
should probably be changed:

if [ "${shellinaboxd_certfile}" = "" ]; then

to

if [ -n "${shellinaboxd_certfile}" ]; then

Otherwise this script looks real good, thanks. :)

>   - Pet portlint
>   - Bump PORTREVISION for package change
>   
>   Reported by:    ed (in the followup of ports/151314)
>   Approved by:    Olivier Cochard-Labbe <olivier@cochard.me> (maintainer)
>   
>   Revision  Changes    Path
>   1.6       +4 -4      ports/www/shellinabox/Makefile
>   1.6       +4 -1      ports/www/shellinabox/files/shellinaboxd.in
> 
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/Makefile.diff?&r1=1.5&r2=1.6&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/shellinabox/files/shellinaboxd.in.diff?&r1=1.5&r2=1.6&f=h
> 



-- 

	Nothin' ever doesn't change, but nothin' changes much.
			-- OK Go

	Breadth of IT experience, and depth of knowledge in the DNS.
	Yours for the right price.  :)  http://SupersetSolutions.com/




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4EA86333.8090804>