Date: Tue, 11 Dec 2007 18:15:59 -0800 From: Sean Bruno <sbruno@miralink.com> To: Hidetoshi Shimokawa <simokawa@FreeBSD.ORG> Cc: freebsd-scsi@freebsd.org, freebsd-firewire@freebsd.org, nate@root.org Subject: Re: scsi_target witness lock error Message-ID: <1197425759.14437.0.camel@home-desk> In-Reply-To: <86sl28snpe.wl%simokawa@FreeBSD.ORG> References: <1197420795.2738.6.camel@iago.office.miralink.com> <86sl28snpe.wl%simokawa@FreeBSD.ORG>
next in thread | previous in thread | raw e-mail | index | archive | help
> --- //depot/vendor/freebsd/src/sys/cam/scsi/scsi_target.c 2007/04/15 08:53:22 > +++ //depot/user/simokawa/firewire_lock/sys/cam/scsi/scsi_target.c 2007/05/21 14:31:55 > @@ -372,10 +372,14 @@ > int retval; > > softc = (struct targ_softc *)kn->kn_hook; > +#if 0 > cam_periph_lock(softc->periph); > +#endif > retval = !TAILQ_EMPTY(&softc->user_ccb_queue) || > !TAILQ_EMPTY(&softc->abort_queue); > +#if 0 > cam_periph_unlock(softc->periph); > +#endif > return (retval); > } Are these two "if 0"'s supposed to be commented out? I'm leaving this out of my RELENG_6 test for now unless you say otherwise. Sean
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1197425759.14437.0.camel>