Date: Sat, 26 Aug 1995 10:19:05 +1000 From: Bruce Evans <bde@zeta.org.au> To: gibbs@freefall.FreeBSD.org, markm@freefall.FreeBSD.org Cc: CVS-commiters@freefall.FreeBSD.org, cvs-user@freefall.FreeBSD.org Subject: Re: cvs commit: src/eBones/registerd Makefile registerd.c Message-ID: <199508260019.KAA06952@godzilla.zeta.org.au>
next in thread | raw e-mail | index | archive | help
>Was there a reason for changing all function declarations from:
>static send_recv(pkt,rpkt,f,_to,addrs)
> KTEXT pkt;
> KTEXT rpkt;
> int f;
> struct sockaddr_in *_to;
> struct hostent *addrs;
>{
>to:
>static int send_recv(KTEXT pkt, KTEXT rpkt, int f, struct sockaddr_in *_to,
> struct hostent *addrs)
>{
Perhaps lack of a visible policy in this area.
>I don't view this as a cleanup at all. It makes unnecessary conflicts with
>the original code and makes it more difficult to incomperate patches from
>outside sources.
I agree.
However, if the original really didn't have an explicit return type, then
there is no way to get it through gcc -Wall -Wreally-all without changing
the key line of the declaration.
Bruce
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199508260019.KAA06952>