Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 03 May 2006 10:54:31 +0200
From:      Alexander Leidinger <Alexander@Leidinger.net>
To:        Doug Ambrisko <ambrisko@ambrisko.com>
Cc:        freebsd-emulation@freebsd.org
Subject:   Re: Linux emulation enhancement to emulate device nodes and some SCSI stuff
Message-ID:  <20060503105431.k8rmf62jlwoscwgc@netchild.homeip.net>
In-Reply-To: <200604272148.k3RLmSOm041069@ambrisko.com>
References:  <200604272148.k3RLmSOm041069@ambrisko.com>

next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Doug Ambrisko <ambrisko@ambrisko.com> (from Thu, 27 Apr 2006 =20
14:48:28 -0700 (PDT)):

> To get the LSI RAID SAS to work under Linux emulation we need to emulate
> more of Linux type stuff.  I've put patches up at:
> =09http://www.ambrisko.com/doug/linux.patches

In case you didn't got any responses: go ahead, we don't have an =20
active linuoxlator guru ATM.

Some generic comments (only a *quick* C-level review, not a =20
design/concept-level review):
---snip--
@@ -470,7 +522,9 @@ linux_fstat64(struct thread *td, struct
  #endif

  =09error =3D kern_fstat(td, args->fd, &buf);
+=09translate_fd_major_minor(td, args->fd, &buf);
  =09if (!error)
+=09=09translate_fd_major_minor(td, args->fd, &buf);
  =09=09error =3D stat64_copyout(&buf, args->statbuf);
---snip---

Bug, missing {} for the "if".

Bye,
Alexander.

--=20
http://www.Leidinger.net  Alexander @ Leidinger.net: PGP ID =3D B0063FE7
http://www.FreeBSD.org     netchild @ FreeBSD.org  : PGP ID =3D 72077137
There are two kinds of pedestrians... the quick and the dead.
=09=09-- Lord Thomas Rober Dewar





Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060503105431.k8rmf62jlwoscwgc>