Date: Thu, 15 Dec 2011 01:35:02 -0800 From: Adrian Chadd <adrian@freebsd.org> To: Bernhard Schmidt <bschmidt@freebsd.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r228514 - head/sys/net80211 Message-ID: <CAJ-Vmo=Wtk8fzt7-OFPAFPV7bHgOJ5uyZ5CW42Jc%2Bwb1z3CPMA@mail.gmail.com> In-Reply-To: <CAAgh0_avwsQ7uzEnwxKtDnnGjck7tJ5AkjqhBYrz2NuRivbbAg@mail.gmail.com> References: <201112150052.pBF0qUA5022051@svn.freebsd.org> <CAAgh0_avwsQ7uzEnwxKtDnnGjck7tJ5AkjqhBYrz2NuRivbbAg@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
On 15 December 2011 00:02, Bernhard Schmidt <bschmidt@freebsd.org> wrote: > Why didn't you remove the mac argument? It is assign from wh->i_addr2 > anyways, seems rather too redundant to me. Because the semantics for that right now are "check that MAC", so it's the callers responsibility to determine which MAC in the header is the relevant one to check against. They're all addr2 though, and I haven't yet thought of a reason it could be addr1 or addr3 (or addr4, for that matter); I just decided to leave it this way so the semantics of "the caller dictates which MAC in the frame is the relevant one to check against" as-is. If you think that's me being a bit overly anal about it, then sure, please go ahead and turf it. :) Personally, I'd like to add an enum field (and then remove the MAC) - the enum field would indicate to acl_check() _which_ ACL is being checked - ie, probe request, association request, and any other frame check request. That way it's precisely clear what the ACL check is for. But again, that's just me being overly picky. :) So in short: if you're happy removing it, remove it. :) Adrian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAJ-Vmo=Wtk8fzt7-OFPAFPV7bHgOJ5uyZ5CW42Jc%2Bwb1z3CPMA>