Date: Sun, 4 Jun 2017 11:06:07 -0700 From: Bryan Drewery <bdrewery@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au>, Ed Maste <emaste@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs Message-ID: <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> In-Reply-To: <20170603161546.D939@besplex.bde.org> References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq Content-Type: multipart/mixed; boundary="qUGl03JLwVNA2HpXXDCCneJWFr43Kmgp9"; protected-headers="v1" From: Bryan Drewery <bdrewery@FreeBSD.org> To: Bruce Evans <brde@optusnet.com.au>, Ed Maste <emaste@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-ID: <543a4144-4f08-8742-5455-0103569d9f4f@FreeBSD.org> Subject: Re: svn commit: r319507 - head/sys/fs/msdosfs References: <201706021839.v52IdrZJ074478@repo.freebsd.org> <20170603161546.D939@besplex.bde.org> In-Reply-To: <20170603161546.D939@besplex.bde.org> --qUGl03JLwVNA2HpXXDCCneJWFr43Kmgp9 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 6/3/2017 12:05 AM, Bruce Evans wrote: > bcopy() is essentially the same as memmove(), but is implemented more > optimally > (the non-use of memmove() in the kernel used to be implememented by > by not having it, but someone broke this by adding an memmove() wrapp= er > which is an extern function that calls bcopy(). This is even slower = than > the inline wrappers used to break intentionally leaving out some of t= he > other functions). In r189170. It seems to me we should change systm.h back to a macro #define memmove(dst, src, len) bcopy((src), (dst), (len)) And then keep the symbol in sys/libkern/memmove.c for the cases where Clang insists on having the symbol for linking. --=20 Regards, Bryan Drewery --qUGl03JLwVNA2HpXXDCCneJWFr43Kmgp9-- --OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQEcBAEBAgAGBQJZNEwPAAoJEDXXcbtuRpfPCDMIAJJuFe9csw5t9YYMW9OfR5UB wA0+zd0E9B1NLt+kAcU5vfLUPvp6HOCUYbZHR6GTmJ0XHMswCaTRXwWDWqztf7Xj +M9W1ILIjnQHpL9wnfPtm8Vw7tt3WWNL1R8Z4wgpZnmCGrH2JRSLhyO63lmTOxHa viTqZAY0YpUC48nOT2C2JCeyG8h2l2a03zjBgTVJLFg9nngr9uxukegtuVWr5Qcr KH/riVda148KPsY8bJieXXurKKr5jK/yOOFZsvI/DO9NP0WVuY4h9/3Vx+MMbwv0 3VViZQRaOXYXri1dLybpX7DKIUQVcoaOG271RVsXIvy/p2gilXRPYgl9s+Rc4Ag= =T/nM -----END PGP SIGNATURE----- --OCrjEcmq8O6hrQ68b5c71DDe4cvVqeKtq--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?543a4144-4f08-8742-5455-0103569d9f4f>