From owner-freebsd-hackers Thu Jul 29 22: 6:11 1999 Delivered-To: freebsd-hackers@freebsd.org Received: from cs.rice.edu (cs.rice.edu [128.42.1.30]) by hub.freebsd.org (Postfix) with ESMTP id 4518C14DF4 for ; Thu, 29 Jul 1999 22:06:07 -0700 (PDT) (envelope-from alc@cs.rice.edu) Received: (from alc@localhost) by cs.rice.edu (8.9.0/8.9.0) id AAA07963; Fri, 30 Jul 1999 00:05:28 -0500 (CDT) Date: Fri, 30 Jul 1999 00:05:28 -0500 From: Alan Cox To: Matthew Dillon Cc: David Greenman , hackers@freebsd.org Subject: Re: patch for behavior changes and madvise MADV_DONTNEED Message-ID: <19990730000528.L10860@cs.rice.edu> References: <199907162234.PAA21850@apollo.backplane.com> <19990720014804.A21777@cs.rice.edu> <199907291856.LAA77471@apollo.backplane.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.95.5us In-Reply-To: <199907291856.LAA77471@apollo.backplane.com>; from Matthew Dillon on Thu, Jul 29, 1999 at 11:56:07AM -0700 Sender: owner-freebsd-hackers@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG Your new "behavior" flag isn't known by vm_map_simply_entry, so map simplification could drop the behavior setting on the floor. I would prefer that the behavior is folded into eflags. Overall, I agree with the direction. Behavior is correctly a map attribute rather than an object attribute. Alan P.S. The MADV_FREE's by malloc/free were disabled by default in -CURRENT and -STABLE prior to the release of 3.2. They were a performance pessimization, slowing down "make world" by ~2%. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message