Date: Fri, 21 Mar 2003 23:25:38 -0700 From: <soralx@cydem.org.ua> To: freebsd-bugs@FreeBSD.ORG Cc: freebsd-hackers@FreeBSD.ORG, dougb@FreeBSD.ORG Subject: Re: misc/41772: can't disable keybell [PATCH] Message-ID: <200303212321.30894.soralx@cydem.org.ua> In-Reply-To: <200303150816.h2F8Ghr2039611@freefall.freebsd.org> References: <200303150816.h2F8Ghr2039611@freefall.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> http://www.freebsd.org/cgi/query-pr.cgi?pr=41772 This appears to be _VERY_ old problem (I don't remember it on 2.2.7-RELEASE, though) In short: the beeper still produces noises (clicks) when shut up with `kbdcontrol -b off` Finally I got some time to look at 'sys/dev/syscons/syscons.c'. However, I only speak i386 Asm fluently (no C at all yet), so could someone plz (fix?) this 3-line 'patch' and commit it? I'd really like to see it MFC'ed in 4.8-RELEASE (as well a this one: 'http://www.FreeBSD.org/cgi/query-pr.cgi?pr=kern/44257' - it works well for my EIDE controller). FreeBSD 4.6.2-RELEASE: =======================8<======================= --- ./syscons.c.ORIG Fri Mar 21 23:10:05 2003 +++ ./syscons.c Fri Mar 21 23:10:37 2003 @@ -3385,6 +3385,9 @@ if (scp != scp->sc->cur_scp && (scp->sc->flags & SC_QUIET_BELL)) return; + if (!(duration && pitch)) + return; + if (scp->sc->flags & SC_VISUAL_BELL) { if (scp->sc->blink_in_progress) return; =======================8<======================= 21.03.2003; 23:20:26 [SorAlx] http://cydem.org.ua/ To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-bugs" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200303212321.30894.soralx>