Date: Thu, 17 Sep 2015 12:58:59 +0100 From: Steven Hartland <steven@multiplay.co.uk> To: Alexey Dokuchaev <danfe@FreeBSD.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r287886 - head/sys/sys Message-ID: <55FAAB03.2090409@freebsd.org> In-Reply-To: <20150917081541.GA65088@FreeBSD.org> References: <201509170003.t8H03uSf070155@repo.freebsd.org> <20150917081541.GA65088@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 17/09/2015 09:15, Alexey Dokuchaev wrote: > On Thu, Sep 17, 2015 at 12:03:56AM +0000, Steven Hartland wrote: >> New Revision: 287886 >> URL: https://svnweb.freebsd.org/changeset/base/287886 >> >> Log: >> Fix kqueue write events for files > 2GB >> >> Due to the use of int's for file offsets in the VOP_WRITE_(PRE|POST) >> macros, kqueue write events for files greater 2GB where never fired. >> >> This caused tail -f on a file greater 2GB to never see updates. > Oh that's an embarrassing bug. > >> MFC after: 1 week > Would you also consider merging to stable/8? Thanks, > > ./danfe 8 isn't supported any more but the patch should apply to stable/8 sources if you maintain your own branch of it. Regards Steve
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?55FAAB03.2090409>