From owner-freebsd-current@FreeBSD.ORG  Tue Jun 22 11:54:10 2004
Return-Path: <owner-freebsd-current@FreeBSD.ORG>
Delivered-To: freebsd-current@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id 16E3116A4CE; Tue, 22 Jun 2004 11:54:10 +0000 (GMT)
Received: from hetzner.co.za (lfw.hetzner.co.za [196.7.18.226])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id A105843D2D; Tue, 22 Jun 2004 11:54:09 +0000 (GMT)
	(envelope-from ianf@hetzner.co.za)
Received: from localhost ([127.0.0.1])
	by hetzner.co.za with esmtp (Exim 3.36 #1)
	id 1Bcjqf-000ERQ-00; Tue, 22 Jun 2004 13:53:57 +0200
To: Andre Oppermann <andre@freebsd.org>
From: Ian FREISLICH <if@hetzner.co.za>
In-Reply-To: Message from Andre Oppermann <andre@freebsd.org> 
   of "Tue, 22 Jun 2004 13:41:35 +0200." <40D81AEF.20579AAC@freebsd.org> 
Date: Tue, 22 Jun 2004 13:53:57 +0200
Sender: ianf@hetzner.co.za
Message-Id: <E1Bcjqf-000ERQ-00@hetzner.co.za>
cc: freebsd-net@freebsd.org
cc: freebsd-current@freebsd.org
Subject: Re: New preview patch for ipfw to pfil_hooks conversion 
X-BeenThere: freebsd-current@freebsd.org
X-Mailman-Version: 2.1.1
Precedence: list
List-Id: Discussions about the use of FreeBSD-current
	<freebsd-current.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-current>
List-Post: <mailto:freebsd-current@freebsd.org>
List-Help: <mailto:freebsd-current-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-current>,
	<mailto:freebsd-current-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Tue, 22 Jun 2004 11:54:10 -0000

Andre Oppermann wrote:
> > There have been about 5 PRs (most with patches) in the past years
> > which all claim to fix this problem indicating that here is a need
> > for a fix.  We rely on the fix in kern/64240 to collect traffic
> > accounting information for billing and statistical purposes.  There
> > hasn't been much interest from the committers in having a look at
> > this even though the work has already been done.
> 
> Could you give me all PR numbers?  That'll make it easier for me
> get the code in.

They all do basically the same thing in varying ways.  I think that
all except for kern/64240 are against -STABLE.  Here's what I can
find quickly.  There may be more lurking.

kern/64240
kern/61259
kern/60377
kern/49959

> > Now that you're actively working on that part of the source, would
> > it be possible to take a look?  I would also be happy to create a
> > new patch to fix this problem against ipfw with pfilhooks if that's
> > what it's going to take to get a fix committed.
> 
> It's ok, I don't need new patches against the converted pfil_hooks
> code.

Cool, thanks.

Ian

--
Ian Freislich