Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 16 May 2019 16:41:55 +0000 (UTC)
From:      Hans Petter Selasky <hselasky@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r347787 - stable/12/sys/dev/mlx5/mlx5_en
Message-ID:  <201905161641.x4GGftPK081011@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: hselasky
Date: Thu May 16 16:41:54 2019
New Revision: 347787
URL: https://svnweb.freebsd.org/changeset/base/347787

Log:
  MFC r347322:
  Ensure the flowtable rules are not freed twice in mlx5en(4).
  This can happen when re-loading the driver.
  
  Sponsored by:	Mellanox Technologies

Modified:
  stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c
==============================================================================
--- stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c	Thu May 16 16:41:21 2019	(r347786)
+++ stable/12/sys/dev/mlx5/mlx5_en/mlx5_en_flow_table.c	Thu May 16 16:41:54 2019	(r347787)
@@ -131,6 +131,9 @@ mlx5e_del_eth_addr_from_flow_table(struct mlx5e_priv *
 
 	if (ai->tt_vec & (1 << MLX5E_TT_ANY))
 		mlx5_del_flow_rule(ai->ft_rule[MLX5E_TT_ANY]);
+
+	/* ensure the rules are not freed again */
+	ai->tt_vec = 0;
 }
 
 static int



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905161641.x4GGftPK081011>