Date: Tue, 15 Nov 2005 03:10:30 -0500 From: Kris Kennaway <kris@obsecurity.org> To: Ade Lovett <ade@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, ports-committers@FreeBSD.org, cvs-all@FreeBSD.org, Kris Kennaway <kris@obsecurity.org> Subject: Re: cvs commit: ports/Mk bsd.php.mk ports/accessibility/at-spi Makefile ports/accessibility/dasher Makefile ports/accessibility/gail Makefile ports/accessibility/gnomemag Makefile ports/accessibility/gnomespeech Makefile ... Message-ID: <20051115081030.GA99853@xor.obsecurity.org> In-Reply-To: <C3803358-C6A2-4AF7-8DAD-00DAFBA5E571@FreeBSD.org> References: <200511150652.jAF6qC9X026352@repoman.freebsd.org> <20051115075033.GA85605@xor.obsecurity.org> <C3803358-C6A2-4AF7-8DAD-00DAFBA5E571@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--a8Wt8u1KmwUX3Y2C
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
On Tue, Nov 15, 2005 at 12:08:15AM -0800, Ade Lovett wrote:
>=20
> On Nov 14, 2005, at 23:50 , Kris Kennaway wrote:
> > Um, this is the poster child for something that should have been run
> > through pointyhat first. I do hope you didn't screw up ;-)
>=20
> I disagree. Look carefully at the top of bsd.autotools.mk. Notice =20
> how all the old variables set a USE_AUTOTOOLS_COMPAT variable which =20
> is processed in *exactly*the*same*way* as USE_AUTOTOOLS.
>=20
> *That* is the heavy-lifting part, which *was* run through pointyhat.
>=20
> Well, actually these three lines:
> .for item in ${USE_AUTOTOOLS}
> AUTOTOOL_${item:C/^([^:]+).*/\1/}${item:M*\:*\:*:C/^[^:]+:[^:]+:([^:]=20
> +)/_\1/}=3D $
> {item:C/^[^:]+:([^:]+).*/\1/}
> .endfor
>=20
> This was merely a mechanical process to essentially sweep the tree, =20
> looking for ports that had USE_AUTOTOOLS_COMPAT defined, and again =20
> mechanically change the Makefile to remove all the old variables, and =20
> replace with:
>=20
> USE_AUTOTOOLS=3D (output from make -V USE_AUTOTOOLS_COMPAT)
>=20
> Think of this as the equivalent to the $Id$ -> $FreeBSD$ tag change a =20
> while back. It really is a no-op.
>=20
> Hell, I even backed out the .warning in bsd.autotools.mk so as *not* =20
> to get email from you about INDEX-4 failing, even though my 7.x boxes =20
> absolutely refuse to build a 4.x tinderbox:
>=20
> =3D=3D=3D> usr.sbin/bootparamd/bootparamd
> cc -O -pipe -DTFTP_DIR=3D\"/tftpboot\" -I. -c /tbox/jails/4-i386/=20
> src/usr.sbin/bootparamd/bootparamd/bootparamd.c
> /tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c: =20
> In function `bootparamproc_whoami_1':
> /tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c:=20
> 47: number of arguments doesn't match prototype
> bootparam_prot.h:78: prototype declaration
> /tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c: =20
> In function `bootparamproc_getfile_1':
> /tbox/jails/4-i386/src/usr.sbin/bootparamd/bootparamd/bootparamd.c:=20
> 112: number of arguments doesn't match prototype
> bootparam_prot.h:81: prototype declaration
> [...]
>=20
> You, sir, have not enough faith :) I can *guarantee* this has gone =20
> through way more testing, in orders of magnitude less time, than =20
> pointyhat could ever begin to achieve.
Great, I'll be holding you to that.
Kris
--a8Wt8u1KmwUX3Y2C
Content-Type: application/pgp-signature
Content-Disposition: inline
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (FreeBSD)
iD8DBQFDeZf2Wry0BWjoQKURApegAJ43vhWiitLyEE69sk5jgDy9XEGVUgCgxlHD
uLXGXPvLjbfMukgZHXhuXxY=
=LxBI
-----END PGP SIGNATURE-----
--a8Wt8u1KmwUX3Y2C--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20051115081030.GA99853>