Date: Wed, 9 Jan 2008 17:24:24 -0500 From: "David Frascone" <dave@frascone.com> To: freebsd-current@freebsd.org Subject: Re: Small patch to fix top in large NIS environments Message-ID: <9cf5ced20801091424k60d136a7xc4a62d0e105fafff@mail.gmail.com> In-Reply-To: <9cf5ced20801090915i3df2d4a1lc057a38b20fc5ac2@mail.gmail.com> References: <9cf5ced20801090915i3df2d4a1lc057a38b20fc5ac2@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
------=_Part_33913_22734575.1199917464826 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline Oops -- should have checked -- I am not used to working as root, so root didn't have my normal .cvsrc. Unified diff attached. -Dave On Jan 9, 2008 12:15 PM, David Frascone <dave@frascone.com> wrote: > > The -u flag to top is supposed to limit uid lookups. But, it was still > spinning through the entire password database with while (getpwent()). At > Cisco, which has a fairly large NIS database, this takes forever, and top > never starts. > > I filed this bug to address it: > http://www.freebsd.org/cgi/query-pr.cgi?pr=119490 > > The attached patch fixes it. This is my first submission, so let me know > if this is the proper order, etc, to post the patches ( i.e. file the bug, > the post a fix) > > -Dave > ------=_Part_33913_22734575.1199917464826 Content-Type: text/plain; name=patch.txt Content-Transfer-Encoding: base64 X-Attachment-Id: f_fb8fvfoh1 Content-Disposition: attachment; filename=patch.txt SW5kZXg6IHVzci5iaW4vdG9wL21hY2hpbmUuYwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09ClJDUyBmaWxlOiAvdXNyL0Zy ZWVCU0QvY3ZzdXAvc3JjL3Vzci5iaW4vdG9wL21hY2hpbmUuYyx2CnJldHJpZXZpbmcgcmV2aXNp b24gMS44MwpkaWZmIC11IC1yMS44MyBtYWNoaW5lLmMKLS0tIHVzci5iaW4vdG9wL21hY2hpbmUu YwkyNiBPY3QgMjAwNyAwODowMDo0MCAtMDAwMAkxLjgzCisrKyB1c3IuYmluL3RvcC9tYWNoaW5l LmMJOSBKYW4gMjAwOCAxNzowODozMiAtMDAwMApAQCAtMjIzLDcgKzIyMyw3IEBACiBzdGF0aWMg aW50IHN3YXBtb2RlKGludCAqcmV0YXZhaWwsIGludCAqcmV0ZnJlZSk7CiAKIGludAotbWFjaGlu ZV9pbml0KHN0cnVjdCBzdGF0aWNzICpzdGF0aWNzKQorbWFjaGluZV9pbml0KHN0cnVjdCBzdGF0 aWNzICpzdGF0aWNzLCBjaGFyIGRvX3VuYW1lcykKIHsKIAlpbnQgcGFnZXNpemU7CiAJc2l6ZV90 IG1vZGVsZW47CkBAIC0yMzcsOSArMjM3LDExIEBACiAJICAgIG1vZGVsZW4gIT0gc2l6ZW9mKHNt cG1vZGUpKQogCQlzbXBtb2RlID0gMDsKIAotCXdoaWxlICgocHcgPSBnZXRwd2VudCgpKSAhPSBO VUxMKSB7CisJaWYgKGRvX3VuYW1lcykgeworCSAgICB3aGlsZSAoKHB3ID0gZ2V0cHdlbnQoKSkg IT0gTlVMTCkgewogCQlpZiAoc3RybGVuKHB3LT5wd19uYW1lKSA+IG5hbWVsZW5ndGgpCiAJCQlu YW1lbGVuZ3RoID0gc3RybGVuKHB3LT5wd19uYW1lKTsKKwkgICAgfQogCX0KIAlpZiAoc21wbW9k ZSAmJiBuYW1lbGVuZ3RoID4gU01QVU5BTUVMRU4pCiAJCW5hbWVsZW5ndGggPSBTTVBVTkFNRUxF TjsKSW5kZXg6IGNvbnRyaWIvdG9wL3RvcC5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC91c3IvRnJl ZUJTRC9jdnN1cC9zcmMvY29udHJpYi90b3AvdG9wLmMsdgpyZXRyaWV2aW5nIHJldmlzaW9uIDEu MjMKZGlmZiAtdSAtcjEuMjMgdG9wLmMKLS0tIGNvbnRyaWIvdG9wL3RvcC5jCTQgTWF5IDIwMDcg MTU6NDI6NTggLTAwMDAJMS4yMworKysgY29udHJpYi90b3AvdG9wLmMJOSBKYW4gMjAwOCAxNzow ODo1NiAtMDAwMApAQCAtNDUwLDcgKzQ1MCw3IEBACiAgICAgfQogCiAgICAgLyogaW5pdGlhbGl6 ZSB0aGUga2VybmVsIG1lbW9yeSBpbnRlcmZhY2UgKi8KLSAgICBpZiAobWFjaGluZV9pbml0KCZz dGF0aWNzKSA9PSAtMSkKKyAgICBpZiAobWFjaGluZV9pbml0KCZzdGF0aWNzLCBkb191bmFtZXMp ID09IC0xKQogICAgIHsKIAlleGl0KDEpOwogICAgIH0K ------=_Part_33913_22734575.1199917464826--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?9cf5ced20801091424k60d136a7xc4a62d0e105fafff>