Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Jun 2000 19:57:23 -0400 (EDT)
From:      adrian@ubergeeks.com
To:        FreeBSD-gnats-submit@freebsd.org
Subject:   ports/19317: update postgres-6 tcl support to 8.2.3.
Message-ID:  <200006152357.TAA15440@cluebie.esolstice.int>

next in thread | raw e-mail | index | archive | help

>Number:         19317
>Category:       ports
>Synopsis:       postgres depends on a very old version of tcl.
>Confidential:   no
>Severity:       non-critical
>Priority:       medium
>Responsible:    freebsd-ports
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          change-request
>Submitter-Id:   current-users
>Arrival-Date:   Thu Jun 15 17:00:03 PDT 2000
>Closed-Date:
>Last-Modified:
>Originator:     Adrian Filipi-Martin
>Release:        FreeBSD 3.4-RELEASE i386
>Organization:
Ubergeeks Consulting
>Environment:

	3.4-RELEASE and 3.3-RELEASe with /usr/ports from 6/14/00.

>Description:

	Ths postgres-6.5.3 port depends on tcl-8.0, when it builds
	and runs fine with 8.2.3.  Note that there did indeed seem
	to be build problems with tcl-8.2.2.  These went away with
	8.2.3.

	I did see the closed PR ports/16951 that indicated that
	there were build problems with previous patches.  I have
	no trouble building with the attached patch.  The simple
	tcl DB application that I have written works just fine.

	N.B.  While at it, I figured out what was wrong with pgaccess
	and uncommented it in the Makefile.  The problem was that
	the source file changed from a tcl script to a bourne shell
	script.

>How-To-Repeat:

	N/A

>Fix:
	
	Apply this patch:

--- Makefile.orig	Fri Apr 21 07:31:17 2000
+++ Makefile	Thu Jun 15 18:50:44 2000
@@ -25,12 +25,12 @@
 # if you want to use the tcl/tk frontend pgaccess, then you need to build
 # postgresql with tcl support by typing: make WITH_TCL=yes
 .if defined(WITH_TCL)
-TCL_INCDIR=	${LOCALBASE}/include/tcl8.0
-TK_INCDIR=	${LOCALBASE}/include/tk8.0
+TCL_INCDIR=	${LOCALBASE}/include/tcl8.2
+TK_INCDIR=	${LOCALBASE}/include/tk8.2
 MAKE_ENV=	WITH_TCL=true TCL_INCDIR=${TCL_INCDIR}
-LIB_DEPENDS=	tcl80.1:${PORTSDIR}/lang/tcl80 \
-		tk80.1:${PORTSDIR}/x11-toolkits/tk80
-CONFIGURE_TCL=	--with-tcl --with-tclconfig="${LOCALBASE}/lib/tcl8.0 ${LOCALBASE}/lib/tk8.0"
+LIB_DEPENDS=	tcl82.1:${PORTSDIR}/lang/tcl82 \
+		tk82.1:${PORTSDIR}/x11-toolkits/tk82
+CONFIGURE_TCL=	--with-tcl --with-tclconfig="${LOCALBASE}/lib/tcl8.2 ${LOCALBASE}/lib/tk8.2"
 .endif
 
 # if you want jdbc, type make WITH_JDBC=yes
@@ -103,14 +103,13 @@
 	@ ${SED} -e 's=!!PREFIX!!=${PREFIX}=g' \
 		${WRKSRC}/Makefile.global.in.old \
 		>> ${WRKSRC}/Makefile.global.in
-# pgaccess (accidentally?) removed from distribution, so leave it for now
-#.if defined(WITH_TCL)
-#	@ ${MV} ${WRKSRC}/bin/pgaccess/pgaccess.tcl \
-#		${WRKSRC}/bin/pgaccess/pgaccess.tcl.orig
-#	@ ${SED} -e "s=/usr/bin/wish=`/usr/bin/which wish8.0`=" \
-#		${WRKSRC}/bin/pgaccess/pgaccess.tcl.orig \
-#		>> ${WRKSRC}/bin/pgaccess/pgaccess.tcl
-#.endif
+.if defined(WITH_TCL)
+	@ ${MV} ${WRKSRC}/bin/pgaccess/pgaccess.sh \
+		${WRKSRC}/bin/pgaccess/pgaccess.sh.orig
+	@ ${SED} -e "s=__wish__=`/usr/bin/which wish8.2`=" \
+		${WRKSRC}/bin/pgaccess/pgaccess.sh.orig \
+		>> ${WRKSRC}/bin/pgaccess/pgaccess.sh
+.endif
 
 post-build:
 .if defined(WITH_JDBC)


>Release-Note:
>Audit-Trail:
>Unformatted:


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe freebsd-ports" in the body of the message




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200006152357.TAA15440>