From owner-cvs-src@FreeBSD.ORG Thu Nov 29 08:49:44 2007 Return-Path: Delivered-To: cvs-src@FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C5D7116A41A; Thu, 29 Nov 2007 08:49:44 +0000 (UTC) (envelope-from kris@FreeBSD.org) Received: from weak.local (freefall.freebsd.org [IPv6:2001:4f8:fff6::28]) by mx1.freebsd.org (Postfix) with ESMTP id D079113C46E; Thu, 29 Nov 2007 08:49:43 +0000 (UTC) (envelope-from kris@FreeBSD.org) Message-ID: <474E7D31.3000904@FreeBSD.org> Date: Thu, 29 Nov 2007 09:49:53 +0100 From: Kris Kennaway User-Agent: Thunderbird 2.0.0.9 (Macintosh/20071031) MIME-Version: 1.0 To: Joseph Koshy References: <200711290643.lAT6hxDS004790@repoman.freebsd.org> In-Reply-To: <200711290643.lAT6hxDS004790@repoman.freebsd.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/dev/hwpmc hwpmc_x86.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 29 Nov 2007 08:49:44 -0000 Joseph Koshy wrote: > jkoshy 2007-11-29 06:43:59 UTC > > FreeBSD src repository > > Modified files: > sys/dev/hwpmc hwpmc_x86.c > Log: > Revert revision 1.4. > > Intel CPUs with family 0x6, model 0xE and later (i.e., Intel Core(TM)) > have a PMC architecture that differs somewhat from previous CPUs in > family 0x6. Even though the basic programming model is similar, the > documented set of legal values that may be loaded into their PMC MSRs > differs from that of the previous PMCs in family 0x6 and reusing bit > values valid for the older PMCs could result in undefined behaviour in > the general case. > > Revision Changes Path > 1.6 +1 -1 src/sys/dev/hwpmc/hwpmc_x86.c What is your expected timeline for fixing this and the other missing CPU family support (Intel Woodcrest, etc)? It's a serious limitation to not be able to run hwpmc on modern CPUs, and I argue that a partial implementation is much better than no implementation. Kris