Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 7 Jan 2009 01:39:57 +0100
From:      Luigi Rizzo <rizzo@iet.unipi.it>
To:        "Bjoern A. Zeeb" <bz@freebsd.org>
Cc:        svn-src-head@freebsd.org, Luigi Rizzo <luigi@freebsd.org>, src-committers@freebsd.org, svn-src-all@freebsd.org
Subject:   Re: svn commit: r186789 - head/sys/boot/forth
Message-ID:  <20090107003957.GA6307@onelab2.iet.unipi.it>
In-Reply-To: <20090106190220.I45399@maildrop.int.zabbadoz.net>
References:  <200901052009.n05K9soF009621@svn.freebsd.org> <20090106190220.I45399@maildrop.int.zabbadoz.net>

next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Jan 06, 2009 at 07:04:25PM +0000, Bjoern A. Zeeb wrote:
> On Mon, 5 Jan 2009, Luigi Rizzo wrote:
> 
> >Author: luigi
> >Date: Mon Jan  5 20:09:54 2009
> >New Revision: 186789
> >URL: http://svn.freebsd.org/changeset/base/186789
> >
> >Log:
> > This patch introduces a number of simplifications to the Forth
> > functions used in the bootloader. The goal is to make the code more
> > readable and smaller (especially because we have size issues
> > in the loader's environment).
> 
> ...
> 
> 
> It's waay to chatty now... I guess some debug stuff slipped in?
> 
> -- starting on </boot/defaults/loader.conf>
> get_file_name has /boot/defaults/loader.conf
> ----- Trying conf /boot/defaults/loader.conf
> Loading /boot/defaults/loader.conf 
> -- starting on </boot/device.hints /boot/loader.conf
> /boot/loader.conf.local>
> get_file_name has /boot/device.hints
> ----- Trying conf /boot/device.hints
> get_file_name has /boot/loader.conf
> ----- Trying conf /boot/loader.conf
> ;get_file_name has /boot/loader.conf.local
> ----- Trying conf /boot/loader.conf.local

whoops... sorry!
try the following patch, i will commit it tomorrow after testing
(you can actually kill the lines altogether if you like)

	cheers
	luigi

Index: support.4th
===================================================================
--- support.4th	(revision 186797)
+++ support.4th	(working copy)
@@ -820,7 +820,7 @@
 \ Interface to loading conf files
 
 : load_conf  ( addr len -- )
-  ." ----- Trying conf " 2dup type cr
+  \ ." ----- Trying conf " 2dup type cr \ debugging
   0 to end_of_file?
   reset_line_reading
   O_RDONLY fopen fd !
@@ -912,7 +912,7 @@
 \ loader_conf_files processing support functions
 
 : get_conf_files ( -- addr len )  \ put addr/len on stack, reset var
-  ." -- starting on <" conf_files strtype ." >" cr
+  \ ." -- starting on <" conf_files strtype ." >" cr \ debugging
   conf_files strget 0 0 conf_files strset
 ;
 
@@ -939,8 +939,7 @@
     pos char+ to pos
   repeat
   addr len pos addr r@ + pos r> -
-  2dup
-  ." get_file_name has " type cr
+  \ 2dup ." get_file_name has " type cr \ debugging
 ;
 
 : get_next_file  ( addr len ptr -- addr len ptr' addr' len' | 0 )



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090107003957.GA6307>