From owner-freebsd-isdn Tue Feb 23 2: 1:19 1999 Delivered-To: freebsd-isdn@freebsd.org Received: from mail.promo.de (mail.Promo.DE [194.45.188.65]) by hub.freebsd.org (Postfix) with ESMTP id 743391102E for ; Tue, 23 Feb 1999 02:01:03 -0800 (PST) (envelope-from stefan.bethke@hanse.de) Received: from d225.promo.de (d225.Promo.DE [194.45.188.225]) by mail.promo.de (8.8.8/8.8.8) with ESMTP id LAA04777 for ; Tue, 23 Feb 1999 11:01:01 +0100 (CET) Date: Tue, 23 Feb 1999 11:01:03 +0100 From: Stefan Bethke To: freebsd-isdn@freebsd.org Subject: Patch: sppp fails to assign address to remote Message-ID: <119878.3128756463@d225.promo.de> Originator-Info: login-id=stefan; server=mail X-Mailer: Mulberry Demo (MacOS) [1.4.2b2, s/n Evaluation] MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="==========00136745==========" Sender: owner-freebsd-isdn@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.org --==========00136745========== Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline When dialling into i4b from a Mac or Windows machine (haven't tried = another i4b yet), something goes wrong when the remote requests an IP address (conf-req 0.0.0.0). Everything works fine with debug set on the interface; when I turn off debug, sppp seems to conf-nak the request with address 0.0.0.0 instead of the interface address. The problem seemingly is a misplaced brace in if_spppsubr.c around line 2705 in sppp_ipcp_RCR(). The following patch should eliminate the problem, and should make dial-in from Windows and Mac work.. Cheers, Stefan -- M=FChlendamm 12 | Voice +49-40-256848, +49-177-3504009 D-22089 Hamburg | e-mail: stefan.bethke@hanse.de Germany | stb@freebsd.org --==========00136745========== Content-Type: text/plain; charset=us-ascii; name="sppp-patch.txt" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="sppp-patch.txt"; size=623 *** if_spppsubr.c.orig Tue Dec 1 21:20:21 1998 --- if_spppsubr.c Tue Feb 23 10:55:28 1999 *************** *** 2701,2712 **** else addlog("%s [not agreed] ", sppp_dotted_quad(desiredaddr)); - - p[2] = hisaddr >> 24; - p[3] = hisaddr >> 16; - p[4] = hisaddr >> 8; - p[5] = hisaddr; } break; } } --- 2701,2712 ---- else addlog("%s [not agreed] ", sppp_dotted_quad(desiredaddr)); } + + p[2] = hisaddr >> 24; + p[3] = hisaddr >> 16; + p[4] = hisaddr >> 8; + p[5] = hisaddr; break; } } --==========00136745==========-- To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-isdn" in the body of the message