From owner-p4-projects@FreeBSD.ORG Sun Jul 6 16:06:47 2008 Return-Path: Delivered-To: p4-projects@freebsd.org Received: by hub.freebsd.org (Postfix, from userid 32767) id 7B9C71065673; Sun, 6 Jul 2008 16:06:47 +0000 (UTC) Delivered-To: perforce@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 0DEAE106566C for ; Sun, 6 Jul 2008 16:06:47 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from smtpoutm.mac.com (smtpoutm.mac.com [17.148.16.68]) by mx1.freebsd.org (Postfix) with ESMTP id E82C28FC17 for ; Sun, 6 Jul 2008 16:06:46 +0000 (UTC) (envelope-from xcllnt@mac.com) Received: from asmtp022-bge351000.mac.com (asmtp022-bge351000 [10.150.69.85]) by smtpoutm.mac.com (Xserve/smtpout005/MantshX 4.0) with ESMTP id m66FoMhf018028; Sun, 6 Jul 2008 08:50:22 -0700 (PDT) MIME-version: 1.0 Content-transfer-encoding: 7BIT Content-type: text/plain; charset=US-ASCII; format=flowed Received: from [192.168.1.102] (209-128-86-226.bayarea.net [209.128.86.226]) by asmtp022.mac.com (Sun Java(tm) System Messaging Server 6.3-6.03 (built Mar 14 2008; 32bit)) with ESMTPSA id <0K3L00EOKDBX4620@asmtp022.mac.com>; Sun, 06 Jul 2008 08:50:22 -0700 (PDT) Sender: xcllnt@mac.com Message-id: From: Marcel Moolenaar To: Takahashi Yoshihiro In-reply-to: <20080706.110943.226722229.nyan@jp.FreeBSD.org> Date: Sun, 06 Jul 2008 08:50:21 -0700 References: <200807051943.m65JhHZ6066371@repoman.freebsd.org> <20080706.110943.226722229.nyan@jp.FreeBSD.org> X-Mailer: Apple Mail (2.926) Cc: marcel@freebsd.org, perforce@freebsd.org Subject: Re: PERFORCE change 144741 for review X-BeenThere: p4-projects@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: p4 projects tree changes List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 06 Jul 2008 16:06:47 -0000 On Jul 5, 2008, at 7:09 PM, Takahashi Yoshihiro wrote: > In article <200807051943.m65JhHZ6066371@repoman.freebsd.org> > Marcel Moolenaar writes: > >> static struct isa_pnp_id isa_i8251_ids[] = { >> {0x0100e4a5, "RSA-98III"}, >> {0} >> }; > >> /* Probe PnP _and_ non-PnP i8251 here. */ >> if (ISA_PNP_PROBE(parent, dev, isa_i8251_ids) != ENXIO) { >> sc->sc_class = &uart_i8251_class; >> return (uart_bus_probe(dev, 0, 0, 0, 0)); >> } > > These are wrong. RSA98-III is based on ns8250 and has extended FIFO > buffer. So I think that the uart_rsa_class should be added. Oh. In your patch you define it as i8251. I only refactored the code. Also, the ns8250 class already supports extended FIFOs, so we don't need a separate class for that. I'll change it... > FYI, RSA series are not for pc98 only. > RSA-PCI (PCI) and RSA-DVII (ISA) exist but not supported yet. Ok, good to know. With the refactored code there's maximum sharing, so UART will support them on other platforms as well... -- Marcel Moolenaar xcllnt@mac.com