From owner-cvs-all Tue Oct 29 5:40:14 2002 Delivered-To: cvs-all@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 879FB37B401; Tue, 29 Oct 2002 05:40:13 -0800 (PST) Received: from sax.sax.de (sax.sax.de [193.175.26.33]) by mx1.FreeBSD.org (Postfix) with ESMTP id 2EE6443EA3; Tue, 29 Oct 2002 05:40:08 -0800 (PST) (envelope-from j@uriah.heep.sax.de) Received: (from uucp@localhost) by sax.sax.de (8.9.3/8.9.3) with UUCP id OAA13372; Tue, 29 Oct 2002 14:40:05 +0100 (CET) Received: from uriah.heep.sax.de (localhost.heep.sax.de [127.0.0.1]) by uriah.heep.sax.de (8.12.5/8.12.5) with ESMTP id g9TDUVWc012245; Tue, 29 Oct 2002 14:30:31 +0100 (MET) (envelope-from j@uriah.heep.sax.de) Received: (from j@localhost) by uriah.heep.sax.de (8.12.5/8.12.5/Submit) id g9TDUVAk012244; Tue, 29 Oct 2002 14:30:31 +0100 (MET) (envelope-from j) Date: Tue, 29 Oct 2002 14:30:31 +0100 From: Joerg Wunsch To: Maxim Konovalov Cc: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/chpass chpass.c Message-ID: <20021029143031.E5639@uriah.heep.sax.de> Reply-To: Joerg Wunsch Mail-Followup-To: Joerg Wunsch , Maxim Konovalov , cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org References: <200210291245.g9TCjXqO008646@repoman.freebsd.org> <20021029155109.X85272-100000@news1.macomnet.ru> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline User-Agent: Mutt/1.2.5i In-Reply-To: <20021029155109.X85272-100000@news1.macomnet.ru>; from maxim@FreeBSD.org on Tue, Oct 29, 2002 at 03:51:23PM +0300 X-Phone: +49-351-2012 669 X-PGP-Fingerprint: DC 47 E6 E4 FF A6 E9 8F 93 21 E0 7D F9 12 D6 4E Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG As Maxim Konovalov wrote: > > Don't try to dereference a NULL pw pointer. This would happen when > > attempting to use chpass -a. > > bin/40471? Only the easy part of it. ;-) The NIS part still needs to be done (if someone's really interested to get chpass -a run against a NIS server). Anyway, i thought fixing a potential segfault in a setuid root program was worth the while... But i'll write a followup, thanks. -- cheers, J"org .-.-. --... ...-- -.. . DL8DTL http://www.sax.de/~joerg/ NIC: JW11-RIPE Never trust an operating system you don't have sources for. ;-) To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message